GNOME Bugzilla – Bug 651226
e_book_new_system_addressbook() should create source in GConf
Last modified: 2011-06-03 09:36:15 UTC
Created attachment 188735 [details] [review] Proposed patch - Part 1 e_book_new_system_addressbook() does not currently create system source in GConf. This means that, if evolution is never executed (to do the necessary GConf work), then e_book_new_system_addressbook() will keep creating new address books. Note that a similar problem was already reported (and fixed) in libecal, see: - http://git.gnome.org/browse/evolution-data-server/commit/?h=pohly-gnome-2-32&id=e6b134fd713addacc770e25f751235ff168fbf66 - http://git.gnome.org/browse/evolution-data-server/commit/?h=pohly-gnome-2-32&id=4c622668652222c6d7817eb5c3c6bbc562073573 Please find attached 2 similar patches to address the same issue in libebook. I have tested that it works as expected with these patches applied (only one "system" address book is created).
Created attachment 188736 [details] [review] Proposed patch - Part 2
These look sane to me; thanks. Please include a reference to the 'corresponding' commit for calendar, in the commit comment. It makes it easier to match them together later, when reading the history. Make sure you reference the *master* commit, of course.
Created attachment 188934 [details] [review] Proposed patch [1/2] Fixed the commit message.
Created attachment 188935 [details] [review] Proposed patch [2/2] Updated commit comment.
Well, I do not know why this should be done in two patches, there is no need for that. Also, the master git does not exhibit this issue, technically, because EBook is deprecated in it, same as ECal, it's replaced with EBook/CalClient API, and this has this done already, because it's sharing the same code. Nonetheless, for the time being, it can be used on master and gnome-3-0 branches.
Created commit 65a0f25 in eds master (3.1.2+) By the way, it's not libical, but libecal ;)