GNOME Bugzilla – Bug 651117
No feedback when there's no suitable application to open a download
Last modified: 2016-02-28 05:39:24 UTC
Topic pretty much says it all. If there's no app to open a downloaded file and you click on the download or use "Open", there's no clear indication that nothing is going to happen. Not sure what's the best we can do here, but we need to improve it.
*** Bug 651118 has been marked as a duplicate of this bug. ***
*** Bug 651119 has been marked as a duplicate of this bug. ***
Wow, what the hell. Epiphany bug, sorry about that :)
I'll work on this one right now, I think. Have hit this a few times... also when some smartass associates with directories you end up with a "browse to" that opens EasyTag.
Created attachment 192710 [details] [review] e-download-widget: handle failed Open action When "Open" fails (via the menu or clicking the widget) we inform the user and offer to browse to the location. Notice that if the reason we couldn't open is that the file is missing, Nautilus will report an error when it doesn't find the full path, it's open to discussion if we should handle this and open the parent folder. Bug #651117
Created attachment 192715 [details] [review] Few nitpicks -- e-download-widget: handle failed Open action When "Open" fails (via the menu or clicking the widget) we inform the user and offer to browse to the location. Notice that if the reason we couldn't open is that the file is missing, Nautilus will report an error when it doesn't find the full path, it's open to discussion if we should handle this and open the parent folder. Bug #651117
Review of attachment 192715 [details] [review]: Using an infobar here feels wrong for some reason. Maybe because we are using them for errors (or "input needed") coming from the pages themselves somehow? I'd like to have some input from a design perspective. ::: lib/widgets/ephy-download-widget.c @@ +200,1 @@ if (ephy_download_do_download_action (download, EPHY_DOWNLOAD_ACTION_AUTO)) This is using AUTO, so you don't really know what action is supposed to happen or...?
Since broken files can appear whatever you're doing on your computer, this should really be fixed system wide. It would be useful to look at how Nautilus deals with broken files when you try to open them. Additionally, Epiphany can offer to redownload the file once it knows it's broken. Something amongst the lines of "File corrupted. Click to redownload".
Nautilus just passes the file to the application, the applications are the ones that handle broken-ness. Instead of the infobar we could paint the downloads-bar button, but that might be harder to discover maybe... don't know, I'm only against a dialog.
Review of attachment 192715 [details] [review]: ::: lib/widgets/ephy-download-widget.c @@ +200,1 @@ if (ephy_download_do_download_action (download, EPHY_DOWNLOAD_ACTION_AUTO)) AUTO means that: - if the download has a content type defined and there's a helper app, then it should open with that app. - if there's no content type or no helper-app, browse to the download
*** This bug has been marked as a duplicate of bug 610586 ***