After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651117 - No feedback when there's no suitable application to open a download
No feedback when there's no suitable application to open a download
Status: RESOLVED DUPLICATE of bug 610586
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 651118 651119 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-05-26 08:03 UTC by Xan Lopez
Modified: 2016-02-28 05:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
e-download-widget: handle failed Open action (3.62 KB, patch)
2011-07-26 23:19 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
Few nitpicks (3.57 KB, patch)
2011-07-27 01:02 UTC, Diego Escalante Urrelo (not reading bugmail)
reviewed Details | Review

Description Xan Lopez 2011-05-26 08:03:18 UTC
Topic pretty much says it all. If there's no app to open a downloaded file and you click on the download or use "Open", there's no clear indication that nothing is going to happen. Not sure what's the best we can do here, but we need to improve it.
Comment 1 Akhil Laddha 2011-05-26 08:10:38 UTC
*** Bug 651118 has been marked as a duplicate of this bug. ***
Comment 2 Akhil Laddha 2011-05-26 08:10:42 UTC
*** Bug 651119 has been marked as a duplicate of this bug. ***
Comment 3 Xan Lopez 2011-05-26 08:13:07 UTC
Wow, what the hell. Epiphany bug, sorry about that :)
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2011-05-29 02:53:18 UTC
I'll work on this one right now, I think. Have hit this a few times... also when some smartass associates with directories you end up with a "browse to" that opens EasyTag.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2011-07-26 23:19:49 UTC
Created attachment 192710 [details] [review]
e-download-widget: handle failed Open action

When "Open" fails (via the menu or clicking the widget) we inform the
user and offer to browse to the location.

Notice that if the reason we couldn't open is that the file is missing,
Nautilus will report an error when it doesn't find the full path, it's
open to discussion if we should handle this and open the parent folder.

Bug #651117
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2011-07-27 01:02:07 UTC
Created attachment 192715 [details] [review]
Few nitpicks

--

e-download-widget: handle failed Open action

When "Open" fails (via the menu or clicking the widget) we inform the
user and offer to browse to the location.

Notice that if the reason we couldn't open is that the file is missing,
Nautilus will report an error when it doesn't find the full path, it's
open to discussion if we should handle this and open the parent folder.

Bug #651117
Comment 7 Xan Lopez 2011-08-23 16:36:53 UTC
Review of attachment 192715 [details] [review]:

Using an infobar here feels wrong for some reason. Maybe because we are using them for errors (or "input needed") coming from the pages themselves somehow? I'd like to have some input from a design perspective.

::: lib/widgets/ephy-download-widget.c
@@ +200,1 @@
   if (ephy_download_do_download_action (download, EPHY_DOWNLOAD_ACTION_AUTO))

This is using AUTO, so you don't really know what action is supposed to happen or...?
Comment 8 Hylke Bons 2011-08-23 18:08:24 UTC
Since broken files can appear whatever you're doing on your computer, this should really be fixed system wide. It would be useful to look at how Nautilus deals with broken files when you try to open them.

Additionally, Epiphany can offer to redownload the file once it knows it's broken. Something amongst the lines of "File corrupted. Click to redownload".
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2011-09-04 20:05:06 UTC
Nautilus just passes the file to the application, the applications are the ones that handle broken-ness.

Instead of the infobar we could paint the downloads-bar button, but that might be harder to discover maybe... don't know, I'm only against a dialog.
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2011-09-04 20:08:29 UTC
Review of attachment 192715 [details] [review]:

::: lib/widgets/ephy-download-widget.c
@@ +200,1 @@
   if (ephy_download_do_download_action (download, EPHY_DOWNLOAD_ACTION_AUTO))

AUTO means that:
- if the download has a content type defined and there's a helper app, then it should open with that app.
- if there's no content type or no helper-app, browse to the download
Comment 11 Michael Catanzaro 2016-02-28 05:39:24 UTC

*** This bug has been marked as a duplicate of bug 610586 ***