After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651089 - [xvimagesink/ximagesink] Remove g_assert from Interface query
[xvimagesink/ximagesink] Remove g_assert from Interface query
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-25 19:59 UTC by sreerenj
Modified: 2011-06-15 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ximagesink:Remove g_assert from interface query. (935 bytes, patch)
2011-05-25 19:59 UTC, sreerenj 		committed Details | Review
ximagesink:Remove g_assert from interface query. (853 bytes, patch)
2011-05-25 19:59 UTC, sreerenj 		committed Details | Review

Description sreerenj 2011-05-25 19:59:06 UTC 
Created attachment 188625 [details] [review]
ximagesink:Remove g_assert from interface query.

Remove the g_assert from both xvimagesink and ximagesink interface queries. Aborting the process if the interface query fails is not seems to be good. Instead returning FALSE is sufficient.
Comment 1 sreerenj 2011-05-25 19:59:55 UTC 
Created attachment 188626 [details] [review]
ximagesink:Remove g_assert from interface query.
Comment 2 Sebastian Dröge (slomo) 2011-05-26 07:06:55 UTC 
commit b977d550df0bdd5c1f104d36f64f84fa23cc1764
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed May 25 14:14:46 2011 +0300

    ximagesink: Remove g_assert from interface query

commit 2f6d9e55cc062d2bca7c965f9a187d07296beb12
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed May 25 14:08:43 2011 +0300

    xvimagesink: Remove the g_assert from interface query