After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651088 - [PATCH] Add a enabled-extensions setting complementing disabled-extensions
[PATCH] Add a enabled-extensions setting complementing disabled-extensions
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 644463 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-05-25 19:43 UTC by Tassilo Horn
Modified: 2011-05-26 06:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add org.gnome.shell.enabled-extensions complementing disabled-extensions. (2.87 KB, patch)
2011-05-25 19:45 UTC, Tassilo Horn 		committed Details | Review

Description Tassilo Horn 2011-05-25 19:43:30 UTC 
The patch I'm going to attach implements the new setting

  org.gnome.shell.enabled-extensions

complementing

  org.gnome.shell.disabled-extensions.

If the former is empty (default), only the extensions not contained in the latter are loaded.  Else, all extensions in the former that are not contained in the latter are loaded.
Comment 1 Tassilo Horn 2011-05-25 19:45:48 UTC 
Created attachment 188624 [details] [review]
Add org.gnome.shell.enabled-extensions complementing disabled-extensions.
Comment 2 John Stowers 2011-05-25 21:41:49 UTC 
also see bug 644463
Comment 3 Colin Walters 2011-05-25 21:48:04 UTC 
*** Bug 644463 has been marked as a duplicate of this bug. ***
Comment 4 Colin Walters 2011-05-25 21:51:49 UTC 
Review of attachment 188624 [details] [review]:

Looks good to me.
Comment 5 Colin Walters 2011-05-25 21:56:18 UTC 
For future reference, I tweaked the commit message:

* Removed the period at the end, our commit style doesn't have them
* Added a body, taken from your bugzilla message

commit 33a3b8046d9028dd1e3d3e3f5da526ef087f1692
Author: Tassilo Horn <tassilo@member.fsf.org>
Date:   Wed May 25 21:34:33 2011 +0200

    Add org.gnome.shell.enabled-extensions complementing disabled-extensions
    
    If the former is empty (default), only the extensions not contained in
    the latter are loaded.  Else, all extensions in the former that are
    not contained in the latter are loaded.
Comment 6 Tassilo Horn 2011-05-26 06:17:31 UTC 
(In reply to comment #5)
> For future reference, I tweaked the commit message:
> 
> * Removed the period at the end, our commit style doesn't have them
> * Added a body, taken from your bugzilla message

Ok, I'll keep that in mind for future patches.

Thanks a lot for the very quick handling. :-)

Bye,
Tassilo