After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651012 - When entering overview first time, windows mispositined, close button clipped
When entering overview first time, windows mispositined, close button clipped
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
: 652076 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-05-24 23:04 UTC by Owen Taylor
Modified: 2013-06-14 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspace: reposition widnows on workspace resize (871 bytes, patch)
2011-05-24 23:09 UTC, Maxim Ermilov
committed Details | Review

Description Owen Taylor 2011-05-24 23:04:26 UTC
Restart shell
Have four windows
Move pointer to upper right quadrant of screen
Trigger overview from keyboard
If necessary, move pointer out of and back into the upper right window
Close button appears partially clipped

Jasper pointed out on IRC that the problem is that the windows are sized and positioned differently on the first enter into the overview, and space isn't left around the edges, so the close button is clipped to the workspace boundaries.
Comment 1 Maxim Ermilov 2011-05-24 23:09:58 UTC
Created attachment 188530 [details] [review]
workspace: reposition widnows on workspace resize

initial window position was broken (part of close button was clipped)
Comment 2 Florian Müllner 2011-06-07 18:44:42 UTC
*** Bug 652076 has been marked as a duplicate of this bug. ***
Comment 3 Dan Winship 2011-06-09 15:57:45 UTC
Comment on attachment 188530 [details] [review]
workspace: reposition widnows on workspace resize

makes sense, fixes the bug
Comment 4 Florian Müllner 2011-06-09 16:55:19 UTC
(In reply to comment #3)
> (From update of attachment 188530 [details] [review])
> makes sense, fixes the bug

I agree that it makes sense, but I'm a bit wary of calling positionWindows() repeatedly for the same animation with different flags (not passing INITIAL in the 2nd invocation works, as it does not affect the scaling properties, but that seems a bit coincidental).

For what it's worth, I've digged into it a little, and the reason for the misplacement is an allocation change of WorkspacesDisplay.actor *after* the overview has been shown (mostly due to delayed style changes). Calling

  this._group.ensure_style();
  this.viewSelector.actor.ensure_style();

in Overview.init() reduces the allocation change significantly (4px on my machine). So far I've been unable to determine what triggers the remaining allocation change - it appears to have some other reason than a style change.
Comment 5 Florian Müllner 2013-06-14 16:35:29 UTC
I can't reproduce this in 3.8 (not surprising considering that the layout code has been rewritten completely since 3.0)