GNOME Bugzilla – Bug 651005
minor wrapper script fixes
Last modified: 2011-05-24 21:16:40 UTC
see patches. Note that even with the fixes in the second patch, you still can't run things out of the source tree, because they need the gsettings schemas. And setting GSETTINGS_SCHEMA_DIR doesn't help, because there's no gschemas.compiled in the build tree.
Created attachment 188520 [details] [review] bin: minor Makefile fixes Files that are generated from configure should be DISTCLEANFILES, not CLEANFILES. Also, include $(libexec_SCRIPTS) everywhere
Created attachment 188521 [details] [review] bin: fix path settings to never include empty path elements. fix typos Things like PYTHONPATH="foo:$PYTHONPATH" are bad, because if PYTHONPATH isn't previously set, you'll end up with a "" element in it, which will be interpreted as ".", which you don't want. Use some tricky bash syntax to say "add : and $PYTHONPATH if PYTHONPATH is set". Also fix a few typos ("licaribou", etc)
These look great, please commit. Thanks. Do you have any idea how we could get it to work with a non-installed gsettings schema?
Maybe run the schema compiler in the build tree in addition to doing it at install time? (In gnome-shell we don't actually bother trying to make it work, we just require that you already did a "make install" even if you're running from the source tree. Which isn't that big a deal since we normally build via jhbuild, which does an install anyway.)
Attachment 188520 [details] pushed as 755d714 - bin: minor Makefile fixes Attachment 188521 [details] pushed as c27aa5d - bin: fix path settings to never include empty path elements. fix typos