GNOME Bugzilla – Bug 650997
Make folks compile with Vala master
Last modified: 2011-06-02 19:03:24 UTC
Created attachment 188511 [details] [review] Play nicely with Vala 0.14 I am playing with what will be the 0.14 release of Vala and a couple of changes were needed in order to make Folks compile. Attached is a patch with the needed changes. This is just a reminder since I am sure this patch will still need more work when the time for bumping our Vala dependency version comes.
Review of attachment 188511 [details] [review]: - var birthday = (DateTime) v.get_boxed (); + unowned DateTime birthday = (DateTime) v.get_boxed (); As you said, this change might be unnecessary with the latest Vala, so let's cut it if possible. yield this._aggregator.add_persona_from_details - (null, this._pstore, details); + (null, this._pstore, (owned) details); This second line should remain indented. Other than that, this works fine with Vala 0.12.0 and 0.12.1, so please make those trivial changes and merge to Folks master.
Merged: commit ff841e27e776573de7ccdf886cf923cf202a77a9 Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk> Date: Tue May 24 18:56:12 2011 +0100 Play nicely with new API in Vala 0.14 Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=650997 backends/key-file/kf-persona-store.vala | 12 +++++++----- folks/backend-store.vala | 13 +++++++------ folks/group-details.vala | 2 +- folks/types.vala | 2 +- tests/tracker/avatar-details-interface.vala | 6 +++--- 5 files changed, 19 insertions(+), 16 deletions(-)