After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650970 - mpeg2enc: fix build with mjpegtools 2.0
mpeg2enc: fix build with mjpegtools 2.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-24 13:45 UTC by Götz Waschk
Modified: 2011-05-25 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix includes for mjpegtools 2.0 (912 bytes, patch)
2011-05-24 13:45 UTC, Götz Waschk
committed Details | Review

Description Götz Waschk 2011-05-24 13:45:49 UTC
Created attachment 188460 [details] [review]
fix includes for mjpegtools 2.0

gstreamer's mpeg2enc element needs a small patch to make it build with mjpegtools 2.0.0.
Comment 1 David Schleef 2011-05-25 00:16:47 UTC
Looks good.

commit 407b02578689804dc6bc47e53be9e87cc1b25597
Author: Götz Waschk <waschk@mandriva.org>
Date:   Tue May 24 15:42:44 2011 +0200

    mpeg2enc: support mjpegtools 2.0
    
    This adds conditional includes for the renamed headers in mjpegtools 2.0.
    Fixes: #650970.
Comment 2 Tim-Philipp Müller 2011-05-25 13:46:34 UTC
This broke things for me with 1.9.0:

 commit 202a5480307de3d02a93dc0bd4e91c3dc3572037
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Wed May 25 14:42:38 2011 +0100

    mpeg2enc: fix build with 1.9.0 release again after recent fixes for mjpegtools 2.0.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=650970
Comment 3 Götz Waschk 2011-05-25 13:51:18 UTC
Thanks, I must admit that I hadn't tested with 1.9.x anymore.