After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650900 - LookingGlass Needs A Bit of Design Love
LookingGlass Needs A Bit of Design Love
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-23 19:34 UTC by Sean Wilson
Modified: 2013-01-21 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Looking Glass image (83.40 KB, image/jpeg)
2011-05-23 19:34 UTC, Sean Wilson 		  Details
Makes lookingGlass look consistent with Gnome Shell (3.90 KB, patch)
2011-10-08 03:51 UTC, Jason Siefken 		none Details | Review
Fixed indentation in gnome-shell.css (3.33 KB, patch)
2011-10-21 04:01 UTC, Jason Siefken 		committed Details | Review
Make lookingGlass look consistent with Gnome Shell (2.73 KB, patch)
2011-10-21 04:08 UTC, Jason Siefken 		committed Details | Review

Description Sean Wilson 2011-05-23 19:34:33 UTC 
Created attachment 188414 [details]
Looking Glass image

The Looking Glass part of GNOME shell could do with some design love. I've attached an image of some work I've done just to make it look better.

Do Ctrl, Alt, lg to open it.
Comment 1 Florian Müllner 2011-05-23 19:40:37 UTC 
(In reply to comment #0)
> The Looking Glass part of GNOME shell could do with some design love.

Not saying it couldn't do with better looks, but given that it is a developer tool users are not expected to ever see, it's hardly important to make its looks consistent with the rest of the interface ...
Comment 2 Finnbarr P. Murphy 2011-06-02 17:56:42 UTC 
Well, it sure looks much better than the existing green terminal look.  In my options, anything that contributes to making the default theme more polished is goodness.
Comment 3 Alexandre Franke 2011-06-09 17:48:46 UTC 
(In reply to comment #0)
> I've attached an image of some work I've done just to make it look better.

Is your work in the form of CSS or is this just a doctored image? If you have code, maybe you could submit a patch?
Comment 4 Jason Siefken 2011-10-08 03:51:16 UTC 
Created attachment 198583 [details] [review]
Makes lookingGlass look consistent with Gnome Shell

I've modified gnome-shell.css's looking glass style rules so it now looks like the proposed image (which is a big improvement!).
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-08 04:18:11 UTC 
If you can, can you make one patch that first re-indents the file correctly, and then the next making the actual changes? This makes it easier for code reviewers to review the patch.
Comment 6 Jason Siefken 2011-10-21 04:01:16 UTC 
Created attachment 199608 [details] [review]
Fixed indentation in gnome-shell.css
Comment 7 Jason Siefken 2011-10-21 04:08:47 UTC 
Created attachment 199609 [details] [review]
Make lookingGlass look consistent with Gnome Shell
Comment 8 Jasper St. Pierre (not reading bugmail) 2011-10-21 04:55:32 UTC 
Review of attachment 199608 [details] [review]:

Looks good.
Comment 9 Jasper St. Pierre (not reading bugmail) 2011-10-21 04:56:11 UTC 
Review of attachment 199609 [details] [review]:

Tried it out. I happened to like it, but talk with other members of the Shell team first.
Comment 10 Jasper St. Pierre (not reading bugmail) 2011-10-21 18:54:40 UTC 
Patches pushed with modified commit message. Thanks!