GNOME Bugzilla – Bug 650893
Kill GdmUser
Last modified: 2011-08-29 21:10:07 UTC
See attached patch. Ray "promised" some API breaks in AccountsService, we may want to wait for those until pushing the change.
Created attachment 188410 [details] [review] Replace GdmUser with AccountsService The GdmUser copy+paste code has been superseded by AccountsService, so kill the former and use the latter.
Review of attachment 188410 [details] [review]: Are the APIs really that compatible? (checks) Looks like they are, OK. However - I bet Owen will want us to at least try to function if accountsservice isn't installed. That may involve some try/catch around e.g.: 23 const AccountsService = imports.gi.AccountsService;
accounts service isn't an optional part of recent versions of GNOME... We didn't add a hard dependency on accounts service earlier so that people could develop gnome-shell with older distros, but I assume at some point there's going to be an expectation that people trying to develop the latest greatest start using it. No idea if that's now, but I want to switch the accounts service library to use gdbus and gain more reasonable interfaces in the process anyway, so probably worthwhile to hold off for now. The current code is serving its role well enough, anyway.
(In reply to comment #3) > accounts service isn't an optional part of recent versions of GNOME... Good. > No idea if that's now, but I want to switch the accounts service library to use > gdbus and gain more reasonable interfaces in the process anyway, so probably > worthwhile to hold off for now. Sure, just wanted to get the patch off my local queue.
(In reply to comment #3) > I assume at some point > there's going to be an expectation that people trying to develop the latest > greatest start using it. Probably not until F15 is actually released. ie, tomorrow. :)
(In reply to comment #5) > (In reply to comment #3) > > I assume at some point > > there's going to be an expectation that people trying to develop the latest > > greatest start using it. > > Probably not until F15 is actually released. ie, tomorrow. :) Until then, it's added to the moduleset :-p
(In reply to comment #5) > (In reply to comment #3) > > I assume at some point > > there's going to be an expectation that people trying to develop the latest > > greatest start using it. > > Probably not until F15 is actually released. ie, tomorrow. :) F15 has been out for a while so ... ;)
I'm not sure the changes hinted at in comment #3 have landed - Ray?
(In reply to comment #8) > I'm not sure the changes hinted at in comment #3 have landed - Ray? I've punted doing those changes for now in lieu of other things. Note as of http://git.gnome.org/browse/gnome-shell/commit/?id=9f1da20161c05c3832c470b959693fefe63d4677 we're using imports.gi.AccountsService so probably makes sense to land your patches now. AccountsService will get a more normal looking api at some point, but we can just fix things up then.
Attachment 188410 [details] pushed as fa786fd - Replace GdmUser with AccountsService (In reply to comment #9) > we're using imports.gi.AccountsService so probably makes sense to land your > patches now. OK. (Apart from rebasing, the pushed patch adds accountsservice as system dependency rather than adding it to the moduleset - it's available for stable releases of both Fedora and Ubuntu, so ...)