After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650807 - Reuse filechooserpreview in the missing files dialog
Reuse filechooserpreview in the missing files dialog
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal enhancement
: 0.14.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-22 17:28 UTC by Jean-François Fortin Tam
Modified: 2011-07-06 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use PreviewWidget in missing file chooser (1003 bytes, patch)
2011-07-05 09:02 UTC, James Putt 		none Details | Review

Description Jean-François Fortin Tam 2011-05-22 17:28:55 UTC 
When you try to load a project that has missing files (because they moved/were renamed), you are presented with a file chooser to specify the new location of the files.

Since bug #586003 has been implemented, maybe it could be possible to reuse filechooserpreview to make it even easier for users to find the file they're looking for.
Comment 1 James Putt 2011-07-05 09:02:24 UTC 
Created attachment 191272 [details] [review]
Use PreviewWidget in missing file chooser

Attached patch just does what's in SourceList, but for the missing file chooser. Is this how you meant for it to be done?
Comment 2 Thibault Saunier 2011-07-05 13:57:26 UTC 
Review of attachment 191272 [details] [review]:

I can't believe it was so simple :)

Looks good to me.
Comment 3 Jean-François Fortin Tam 2011-07-06 02:05:50 UTC 
This has now been committed to master. Thanks for your contribution, James :)


commit dde02390bf3f6e25d557e7a125fd543e4a15a5eb
Author: James Putt <putt.james@gmail.com>
Date:   Tue Jul 5 22:03:16 2011 -0400

    Reuse filechooserpreview in the missing files dialog
    
    Fixes bug #650807
Comment 4 James Putt 2011-07-06 08:33:01 UTC 
Just a drop in the bucket of an awesome project!