GNOME Bugzilla – Bug 650762
gtk_misc_set_alignment replacement with the new API functions
Last modified: 2014-10-20 03:49:42 UTC
Created attachment 188316 [details] [review] Replacing the function gtk_misc_set_alignment in gtk/gtkfilechooserbutton.c The gtk_misc_set_alignment function needs to be replaced with the gtk_widget_set_halign and gtk_widget_set_valign functions. This bug was opened to submit here some of the patches for being reviewed
Created attachment 188317 [details] [review] Replacing the function gtk_misc_set_alignment in gtk/gtkcustompaperunixdialog.c
Created attachment 188318 [details] [review] Replacing the gtk_misc_set_alignment function in gtk/gtknotebook.c
Created attachment 188321 [details] [review] Replacing the gtk_misc_set_alignment function in gtk/gtkcolorsel.c
Review of attachment 188316 [details] [review]: Looks good
Review of attachment 188317 [details] [review]: Looks good
Review of attachment 188318 [details] [review]: Looks fine
Review of attachment 188321 [details] [review]: Looks good
Thanks again for the reviews Matthias. What do you think that is better, to keep posting here the patches as soon as I have more, or to open a new bug with another 3 or 4 patches?
The following fixes have been pushed: 7839c27 gtk/gtkcolorsel: gtk_misc_set_alignment replacing 95fd3d7 gtk/gtknotebook: gtk_misc_set_alignment replacing d291709 gtkcustompaperunixdialog: gtk_misc_set_alignment ee18c5f gtk/gtkfilechooserbutton: gtk_misc_set_alignment Hey Diego, either way works. Leaving this bug open for now.
Created attachment 188960 [details] [review] gtk/gtkcolorsel: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkcolorsel.c
Created attachment 188961 [details] [review] gtk/gtknotebook: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtknotebook.c
Created attachment 188962 [details] [review] gtkcustompaperunixdialog: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkcustompaperunixdialog.c
Created attachment 188963 [details] [review] gtk/gtkfilechooserbutton: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkfilechooserbutton.c
hey, it has been a while, but I already have a few more patches ready
Created attachment 189512 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkmenuitem.c
Created attachment 189513 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkradiomenuitem.c
Created attachment 189514 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkmountoperation.c
Created attachment 189515 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkmessagedialog.c
Review of attachment 189512 [details] [review]: Looks fine
Review of attachment 189513 [details] [review]: This too
Review of attachment 189514 [details] [review]: This too
Review of attachment 189515 [details] [review]: Looks good too
Created attachment 189517 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkcellrendereraccel.c
Created attachment 189519 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkfilechooserdefault.c
Created attachment 189520 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkpagesetupunixdialog.c
Created attachment 189521 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkprintbackend.c
Created attachment 189522 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkprintunixdialog.c
Review of attachment 189517 [details] [review]: Fine
Review of attachment 189519 [details] [review]: No problem
Review of attachment 189520 [details] [review]: Looks good
Review of attachment 189521 [details] [review]: Yep
Review of attachment 189522 [details] [review]: Keep them coming
Created attachment 189616 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkassistant.c
Created attachment 189617 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkfontsel.c
Created attachment 189618 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtkprinteroptionwidget.c
Created attachment 189620 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtktoolitemgroup.c
Review of attachment 189616 [details] [review]: another good patch
Review of attachment 189617 [details] [review]: and another one
Review of attachment 189618 [details] [review]: This one too
Review of attachment 189620 [details] [review]: also fine
The following fixes have been pushed: 71dc365 gtktoolitemgroup: gtk_misc_set_alignment replacing b16c973 gtkprinteroptionwidget: gtk_misc_set_alignment 90e2fdc gtk/gtkfontsel: gtk_misc_set_alignment replacing c92600c gtk/gtkassistant: gtk_misc_set_alignment replacing 0a75ffd gtkprintunixdialog: gtk_misc_set_alignment replace a06dfd6 gtkprintbackend: gtk_misc_set_alignment replacing eb54d93 gtkpagesetupunixdialog: gtk_misc_set_alignment 8af988e gtkfilechooserdefault: gtk_misc_set_alignment df9d7cf gtkcellrendereraccel: gtk_misc_set_alignment cc0be1f gtk/gtkmessagedialog: gtk_misc_set_alignment 0924e4d gtk/gtkmountoperation: gtk_misc_set_alignment cb03ea5 gtk/gtkradiomenuitem: gtk_misc_set_alignment 49e62d2 gtk/gtkmenuitem: gtk_misc_set_alignment replacing
Created attachment 189685 [details] [review] gtktoolitemgroup: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtktoolitemgroup.c
Created attachment 189686 [details] [review] gtkprinteroptionwidget: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkprinteroptionwidget.c
Created attachment 189687 [details] [review] gtk/gtkfontsel: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkfontsel.c
Created attachment 189688 [details] [review] gtk/gtkassistant: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkassistant.c
Created attachment 189689 [details] [review] gtkprintunixdialog: gtk_misc_set_alignment replace Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkprintunixdialog.c
Created attachment 189690 [details] [review] gtkprintbackend: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkprintbackend.c
Created attachment 189691 [details] [review] gtkpagesetupunixdialog: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkpagesetupunixdialog.c
Created attachment 189692 [details] [review] gtkfilechooserdefault: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkfilechooserdefault.c
Created attachment 189693 [details] [review] gtkcellrendereraccel: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkcellrendereraccel.c
Created attachment 189694 [details] [review] gtk/gtkmessagedialog: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkmessagedialog.c
Created attachment 189695 [details] [review] gtk/gtkmountoperation: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkmountoperation.c
Created attachment 189696 [details] [review] gtk/gtkradiomenuitem: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkradiomenuitem.c
Created attachment 189697 [details] [review] gtk/gtkmenuitem: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkmenuitem.c
Thanks for all the reviews Matthias! I will keep sending tiny patches for review here
Created attachment 189782 [details] [review] Replacing the function gtk_misc_set_alignment () in gtkaboutdialog.c
Created attachment 189783 [details] [review] Replacing the function gtk_misc_set_alignment () in gtkappchooserdialog.c
Created attachment 189784 [details] [review] Replacing the function gtk_misc_set_alignment () in demos/gtk-demo/changedisplay.c
Created attachment 189785 [details] [review] Replacing the function gtk_misc_set_alignment () in demos/gtk-demo/pickers.c
Created attachment 189786 [details] [review] Replacing the function gtk_misc_set_alignment () in demos/gtk-demo/sizegroup.c
Created attachment 189787 [details] [review] Replacing the function gtk_misc_set_alignment () in demos/gtk-demo/ui_manager.c
Created attachment 189788 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/testcalendar.c
Created attachment 189789 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/testgtk.c
Created attachment 189790 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/prop-editor.c
Created attachment 190062 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/testcombochange.c
Created attachment 190063 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/testentryicons.c
Created attachment 190064 [details] [review] Replacing the function gtk_misc_set_alignment () in tests/testfilechooserbutton.c
Created attachment 190069 [details] [review] Replacing the function gtk_misc_set_alignment () in gtk/gtklockbutton.c
The following fixes have been pushed: ca317c6 tests-prop-editor:gtk_misc_set_alignment replacing 173cc86 testgtk: gtk_misc_set_alignment replacing fd1fabf testcalendar: gtk_misc_set_alignment replacing bd69e6a demo-ui_manager: gtk_misc_set_alignment replacing 464fa47 demo-sizegroup: gtk_misc_set_alignment replacing 9b31aff demo-pickers: gtk_misc_set_alignment replacing a3719d3 demo-changedisplay:gtk_misc_set_alignment replace 372a907 gtkappchooserdialog: gtk_misc_set_alignment 9dfff27 gtkaboutdialog: gtk_misc_set_alignment replacing
Created attachment 195014 [details] [review] tests-prop-editor:gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in tests/prop-editor.c
Created attachment 195015 [details] [review] testgtk: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in tests/testgtk.c
Created attachment 195016 [details] [review] testcalendar: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in tests/testcalendar.c
Created attachment 195017 [details] [review] demo-ui_manager: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in demos/gtk-demo/ui_manager.c
Created attachment 195018 [details] [review] demo-sizegroup: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in demos/gtk-demo/sizegroup.c
Created attachment 195019 [details] [review] demo-pickers: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in demos/gtk-demo/pickers.c
Created attachment 195020 [details] [review] demo-changedisplay:gtk_misc_set_alignment replace Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in demos/gtk-demo/changedisplay.c
Created attachment 195021 [details] [review] gtkappchooserdialog: gtk_misc_set_alignment Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkappchooserdialog.c
Created attachment 195022 [details] [review] gtkaboutdialog: gtk_misc_set_alignment replacing Replacing the function gtk_misc_set_alignment () with gtk_widget_set_halign () and gtk_widget_set_valign () in gtk/gtkaboutdialog.c
I reopen this bug as seems that there still are some uses of the gtk_misc_set_alignment() api: gtk/gtkbutton.c: gtk_misc_set_alignment (misc, priv->xalign, priv->yalign); gtk/gtkbutton.c: gtk_misc_set_alignment (GTK_MISC (label), priv->xalign, priv->yalign); gtk/gtklabel.c: * aligns in its available space, see gtk_misc_set_alignment(). gtk/gtklabel.c: * gtk_misc_set_alignment() instead. gtk_label_set_justify() has no gtk/gtklockbutton.c: gtk_misc_set_alignment (GTK_MISC (priv->label_lock), 0, 0.5); gtk/gtklockbutton.c: gtk_misc_set_alignment (GTK_MISC (priv->label_unlock), 0, 0.5); gtk/gtkmenuitem.c: gtk_misc_set_alignment (GTK_MISC (accel_label), 0.0, 0.5); gtk/gtktoolbutton.c: gtk_misc_set_alignment (GTK_MISC (label), gtk/gtktoolbutton.c: gtk_misc_set_alignment (GTK_MISC (label), gtk/gtktoolbutton.c: gtk_misc_set_alignment (GTK_MISC (icon), gtk/gtktoolbutton.c: gtk_misc_set_alignment (GTK_MISC (icon), tests/testcombochange.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testcombochange.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testcombochange.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testentryicons.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testentryicons.c: gtk_misc_set_alignment (GTK_MISC(label), 0.0, 0.5); tests/testentryicons.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testentryicons.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testentryicons.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testfilechooserbutton.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); tests/testfilechooserbutton.c: gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
Created attachment 203867 [details] [review] gtkmenuitem
Created attachment 203868 [details] [review] testcombochanges
Created attachment 203869 [details] [review] testentryicons
Whats left now is just the cases where we can't drop gtkmisc yet because it interacts with labels in size groups
this is now done