After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650750 - Allow one to use GEGL to manipulate video
Allow one to use GEGL to manipulate video
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2011-05-21 17:24 UTC by Jon Nordby
Modified: 2017-01-27 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Proposed patch for minimal level of integration (17.85 KB, patch)
2011-05-21 17:28 UTC, Jon Nordby
needs-work Details | Review

Description Jon Nordby 2011-05-21 17:24:37 UTC
Gegl is a library that provides an image processing framework and a number of image processing operations. See

Integrating Gegl with GStreamer gives application developers very powerful image/video processing capabilities, without these having to be (re)implemented by GStreamer itself. This are especially of interest to video editing/manipulation software like Pitivi.
Comment 1 Jon Nordby 2011-05-21 17:28:01 UTC
Created attachment 188305 [details] [review]
Proposed patch for minimal level of integration
Comment 2 Sebastian Dröge (slomo) 2011-05-23 08:41:20 UTC
Please prepare a patch against gst-plugins-bad for this. New plugins are first added to gst-plugins-bad. I'll review this later nonetheless :)
Comment 3 Sebastian Dröge (slomo) 2011-05-23 10:39:48 UTC
Review of attachment 188305 [details] [review]:

::: ext/
@@ +161,3 @@
+    $(GEGL_DIR)

Wrong indention

@@ +184,3 @@
 	taglib \
+	wavpack \
+    gegl

Same here

::: ext/gegl/
@@ +3,3 @@
+libgstgegl_la_SOURCES = gstgegl.c gstgeglfilter.c

There's a space missing between the gst-plugins-base and base CFLAGS

@@ +4,3 @@
+libgstgegl_la_SOURCES = gstgegl.c gstgeglfilter.c

Remove the GST_LIBS from the beginning and only keep the second

::: ext/gegl/gstgeglfilter.c
@@ +52,3 @@
+Set pads dynamically based on the formats that Babl supports
+Support a more GStreamer native type, like YUV420 in Gegl/Babl

Which other formats are supported by Gegl/Babl? But yes, support for them would be great too but that can happen later :)

@@ +111,3 @@
+  Babl *format = babl_format ("RGBA u8");
+  // Push buffer to GEGL

Don't use C++/C99 comments

@@ +113,3 @@
+  // Push buffer to GEGL
+  gegl_buffer_set (self->buffer, &roi, format,

You should use the GStreamer rowstride here, look at libgstvideo (especially video.h) for how to get the rowstride and other information from caps

@@ +116,3 @@
+  // Get result back from GEGL
+  if (self->input_node) {

Shouldn't there always be an input node?

@@ +134,3 @@
+      if (self->input_node)
+        g_object_unref (self->input_node);
+      self->input_node = g_value_dup_object (value);

Shouldn't this be protected with the object lock too? And then take the object lock in transform_ip and set_caps when changing something in one of the gegl nodes.

@@ +193,3 @@
+  trans_class->set_caps = gst_gegl_filter_set_caps;
+  trans_class->transform_ip = gst_gegl_filter_transform_ip;

Use = GST_DEBUG_FUNCPTR (gst_gegl_filter_transform_ip) here and for setcaps

@@ +206,3 @@
+  pspec = g_param_spec_object ("input-node",
+      "Input node",
+      "Gegl node to take input from.", GEGL_TYPE_NODE, G_PARAM_READWRITE);


@@ +217,3 @@
+  pspec = g_param_spec_object ("output-node",
+      "Output node", "Gegl node for the output.", GEGL_TYPE_NODE,


@@ +225,3 @@
+gst_gegl_filter_init (GstGeglFilter * self, GstGeglFilterClass * klass)
+  self->output_node = gegl_node ("gegl:buffer-source", NULL);

You should unref this in GObject::dispose
Comment 4 Tim-Philipp Müller 2012-06-16 14:57:28 UTC
Also, please port it to the new GStremer 0.11/1.0 API (git master) :)
Comment 5 Christian Fredrik Kalager Schaller 2012-10-23 12:40:07 UTC
Hi Jon, do you plan on updating this element based on the feedback so we can get it included?
Comment 6 Jon Nordby 2012-10-23 13:18:06 UTC
Hi Christian,
yes, I would like to get it in. And to write up a bit how GEGL and GStreamer could be used together for more advanced video processing/compositing scenarios.
Hope to find time for it perhaps the coming 2 weeks.
Comment 7 Sebastian Dröge (slomo) 2013-08-23 11:05:58 UTC
Are you planning to work on this any time soon? This also has to be updated to GStreamer 1.0
Comment 8 Jon Nordby 2013-08-23 12:31:20 UTC
Hi Sebastian.
Realistically speaking it is not very likely. The usecase I had for it has been solved in a different way, and I've reduced my involvement in GEGL a bit.

That said, if someone wants to hack on it, I'll happily help with questions that may come up.
Comment 9 Sebastian Dröge (slomo) 2013-08-23 12:34:50 UTC
Ok, let's just close it for now then until someone else is interested in working on this. No point in keeping the bug open forever without any action :)