After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650665 - CallyActor shouldn't add by default "press", "release" and "click"
CallyActor shouldn't add by default "press", "release" and "click"
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: cally
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Alejandro Piñeiro Iglesias (IRC: infapi00)
clutter-maint
Depends on:
Blocks: 650666
 
 
Reported: 2011-05-20 12:45 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2011-05-25 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removes default actions (5.36 KB, patch)
2011-05-23 19:40 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		none Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-20 12:45:30 UTC 
Right now CallyActor implements AtkAction and also add as default "press", "release" and "click".

This is due historical reasons, as at the beginning some apps started to use some actors (mainly ClutterTexture) directly as buttons.

But now, we start to have toolkits that provides widgets with a full meaning, so those actions should be only available for objects that makes sense to do that.

So, as discussed on bug 626660 comment 10 and at bug 644253 comment 11, those actions shouldn't be added by default.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-23 19:40:54 UTC 
Created attachment 188415 [details] [review]
Removes default actions

This patch removes the actions and also update the AtkAction implementation comments.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-23 19:41:33 UTC 
Patch attached not committed yet meanwhile I work on bug 650666, as both are heavily related.
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-25 16:42:53 UTC 
commit 46aadb745b819b2f69b69b119ce70ce84ab04cb9
Author: Alejandro Piñeiro <apinheiro@igalia.com>
Date:   Thu May 19 12:58:36 2011 +0200

    [cally] Removed default actions on CallyActor

Closing bug as FIXED.