After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650590 - cell-renderer-expander: fix rendering with GTK+3
cell-renderer-expander: fix rendering with GTK+3
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-19 14:16 UTC by Cosimo Cecchi
Modified: 2011-05-23 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cell-renderer-expander: fix rendering with GTK+3 (2.02 KB, patch)
2011-05-19 14:16 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-05-19 14:16:20 UTC 
Here's a patch that fixes some rendering issues of EmpathyCellRendererExpander with GTK+3. The commit message has a better description of the changes.
Comment 1 Cosimo Cecchi 2011-05-19 14:16:22 UTC 
Created attachment 188129 [details] [review]
cell-renderer-expander: fix rendering with GTK+3

There are basically three issues here:
- the renderer doesn't add the GTK_STYLE_CLASS_EXPANDER style class when
  rendering, which blocks the theme to apply the intended colors.
- the GtkStateFlags that were set on the context were using GTK_STATE_*
  instead of GTK_STATE_FLAG_*
- the flags set on the context were incomplete, as they were just using
  ACTIVE/NORMAL for expanded/collapsed and not SELECTED/FOCUSED/...
Comment 2 Guillaume Desmottes 2011-05-20 11:27:09 UTC 
Review of attachment 188129 [details] [review]:

++

3.0 and master please.
Thanks!
Comment 3 Cosimo Cecchi 2011-05-23 13:55:46 UTC 
Thanks, pushed!

Attachment 188129 [details] pushed as d0e556d - cell-renderer-expander: fix rendering with GTK+3