After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650542 - Some small UI tweaks
Some small UI tweaks
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-19 05:11 UTC by Cosimo Cecchi
Modified: 2011-09-01 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
preferences: show a frame around the book shelf treeview (1.14 KB, patch)
2011-05-19 05:11 UTC, Cosimo Cecchi
committed Details | Review
prefs: remove the vertical grid line for the bookshelf treeview (1.20 KB, patch)
2011-05-19 05:11 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2011-05-19 05:11:34 UTC
Hi, attached are some small UI tweaks that make the Devhelp preferences window look nicer.
Comment 1 Cosimo Cecchi 2011-05-19 05:11:40 UTC
Created attachment 188092 [details] [review]
preferences: show a frame around the book shelf treeview

It's in a scrolled window, so the tree is "floating" in the window
without a frame.
Comment 2 Cosimo Cecchi 2011-05-19 05:11:50 UTC
Created attachment 188093 [details] [review]
prefs: remove the vertical grid line for the bookshelf treeview

It's redundant, as there's enough whitespace already; also, the dotted
line doesn't look very good.
Comment 3 Javier Jardón (IRC: jjardon) 2011-06-08 12:10:22 UTC
Review of attachment 188092 [details] [review]:

This seems to be applied some time ago
Comment 4 Cosimo Cecchi 2011-06-08 13:27:25 UTC
(In reply to comment #3)
> Review of attachment 188092 [details] [review]:
> 
> This seems to be applied some time ago

Not true, I can't see the patch on git master.
Comment 5 Javier Jardón (IRC: jjardon) 2011-06-08 15:14:36 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Review of attachment 188092 [details] [review] [details]:
> > 
> > This seems to be applied some time ago
> 
> Not true, I can't see the patch on git master.
 
I mean, the "shadow-type" property is not set in the GtkBuilder file anymore.
Comment 6 Cosimo Cecchi 2011-06-08 15:36:11 UTC
(In reply to comment #5)

> I mean, the "shadow-type" property is not set in the GtkBuilder file anymore.

Yeah, my patch adds a shadow to that scrolled window, master doesn't have the shadow.
Comment 7 Cosimo Cecchi 2011-09-01 20:06:05 UTC
Attachment 188092 [details] pushed as ba05216 - preferences: show a frame around the book shelf treeview
Attachment 188093 [details] pushed as fb92cb3 - prefs: remove the vertical grid line for the bookshelf treeview

Pushed now.