GNOME Bugzilla – Bug 650542
Some small UI tweaks
Last modified: 2011-09-01 20:06:11 UTC
Hi, attached are some small UI tweaks that make the Devhelp preferences window look nicer.
Created attachment 188092 [details] [review] preferences: show a frame around the book shelf treeview It's in a scrolled window, so the tree is "floating" in the window without a frame.
Created attachment 188093 [details] [review] prefs: remove the vertical grid line for the bookshelf treeview It's redundant, as there's enough whitespace already; also, the dotted line doesn't look very good.
Review of attachment 188092 [details] [review]: This seems to be applied some time ago
(In reply to comment #3) > Review of attachment 188092 [details] [review]: > > This seems to be applied some time ago Not true, I can't see the patch on git master.
(In reply to comment #4) > (In reply to comment #3) > > Review of attachment 188092 [details] [review] [details]: > > > > This seems to be applied some time ago > > Not true, I can't see the patch on git master. I mean, the "shadow-type" property is not set in the GtkBuilder file anymore.
(In reply to comment #5) > I mean, the "shadow-type" property is not set in the GtkBuilder file anymore. Yeah, my patch adds a shadow to that scrolled window, master doesn't have the shadow.
Attachment 188092 [details] pushed as ba05216 - preferences: show a frame around the book shelf treeview Attachment 188093 [details] pushed as fb92cb3 - prefs: remove the vertical grid line for the bookshelf treeview Pushed now.