GNOME Bugzilla – Bug 650513
metacity doesn't compile with --with-gtk=3.0
Last modified: 2011-05-19 16:47:29 UTC
Created attachment 188059 [details] [review] start fixing gtk3 fallout Hi, Metacity's configure script offers the option to compile it against GTK3 using the --with-gtk=3.0 option. Sadly, this doesn't work (at all). I started looking at the fallout and created two patches, but I gave up after fixing these 3 issues when another 6 showed up. I don't know how to handle the ifdefs exactly as there's nothing there yet to differentiate between the two versions, but perhaps a block like this in configure.ac would be preferred? AM_CONDITIONAL([HAVE_GTK_2],[test "$with_gtk" = "2.0"]) AM_CONDITIONAL([HAVE_GTK_3],[test "$with_gtk" = "3.0"]) and thus wrap the code in HAVE_GTK_3 accordingly? Attached is the start to let metacity compile with gtk3. So I wonder if metacity been tested with recent gtk3 versions?
Note mutter (the metacity successor) was ported to GTK3 for GNOME 3, and it was a lot of work: https://bugzilla.gnome.org/show_bug.cgi?id=630203 (and others, just search bugzilla) There were some subtle issues: https://bugzilla.gnome.org/show_bug.cgi?id=630195 Then later, we removed GTK+2 support: https://bugzilla.gnome.org/show_bug.cgi?id=633133 Honestly, unless you're stepping up to replicate this work (which I would cheer!) I'd rather just kill off the configure option for GTK3. metacity is only part of the fallback story for GNOME 3 now, and ultimately once we can rely on software rendering better, irrelevant.
I'm fine with removing the gtk3 switch as it implies the code builds and is tested, which it isn't. So zapping it removes the impression. Thanks.
(In reply to comment #2) > I'm fine with removing the gtk3 switch as it implies the code builds and is > tested, which it isn't. So zapping it removes the impression. Thanks. Done then, thanks!