After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650462 - gstomx_aacdec don't set params to omx in port components
gstomx_aacdec don't set params to omx in port components
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 0.10.2
Assigned To: Felipe Contreras (banned)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-18 09:17 UTC by Wei.Feng
Modified: 2011-10-29 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for omx/gstomx_aacdec.c (1.37 KB, patch)
2011-05-18 09:17 UTC, Wei.Feng 		none Details | Review
new patch (2.25 KB, patch)
2011-05-20 04:15 UTC, Wei.Feng 		accepted-commit_now Details | Review

Description Wei.Feng 2011-05-18 09:17:34 UTC 
Created attachment 188019 [details] [review]
patch for omx/gstomx_aacdec.c

aacparse or qtdemux will parse out aac channels and sample rate and stream type, but gstomx_aacdec don't set them to omx aacdec commponent, which will cause some implementation(like bellagio) fault. Although maybe it's redundant, I think it is necessary.
Comment 1 Sebastian Dröge (slomo) 2011-05-18 12:10:20 UTC 
You should also add these fields to the sinkpad template caps then
Comment 2 Felipe Contreras (banned) 2011-05-18 13:17:11 UTC 
(In reply to comment #0)
> Created an attachment (id=188019) [details] [review]
> patch for omx/gstomx_aacdec.c

Looks fine to me. But I agree with the comment from slomo.
Comment 3 Wei.Feng 2011-05-19 02:19:53 UTC 
(In reply to comment #1)
> You should also add these fields to the sinkpad template caps then

Do you mean caps in omx/gstomx.conf.in? They are already there except stream-type.
Comment 4 Felipe Contreras (banned) 2011-05-19 10:44:00 UTC 
(In reply to comment #3)
> (In reply to comment #1)
> > You should also add these fields to the sinkpad template caps then
> 
> Do you mean caps in omx/gstomx.conf.in? They are already there except
> stream-type.

Yes, stream-type should be there.
Comment 5 Wei.Feng 2011-05-20 04:15:46 UTC 
Created attachment 188199 [details] [review]
new patch
Comment 6 Felipe Contreras (banned) 2011-05-20 13:34:57 UTC 
Review of attachment 188199 [details] [review]:

This looks like two patches in one: it's also adding "framed=true".

I have split the patch into two and committed. Thanks.
Comment 7 Felipe Contreras (banned) 2011-05-20 13:39:25 UTC 
Marking as fixed.