After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650445 - gnome-suites-core-deps-3.2: Switch over to js185 release for gjs
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-05-17 23:12 UTC by Colin Walters
Modified: 2011-05-19 02:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs (2.88 KB, patch)
2011-05-17 23:12 UTC, Colin Walters
needs-work Details | Review
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs (2.93 KB, patch)
2011-05-18 17:23 UTC, Colin Walters
none Details | Review
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs (1.91 KB, patch)
2011-05-18 17:53 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2011-05-17 23:12:23 UTC
This moves gjs over to the standalone js185-1.0.0.tar.gz release
from the SpiderMonkey team.
Comment 1 Colin Walters 2011-05-17 23:12:25 UTC
Created attachment 188003 [details] [review]
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs
Comment 2 Craig Keogh 2011-05-18 09:57:48 UTC
Review of attachment 188003 [details] [review]:

When I attempt to build js185:

jhbuild buildone js185
*** Checking out js185 *** [1/1]
curl --continue-at - -L https://ftp.mozilla.org/pub/mozilla.org/js/js185-1.0.0.tar.gz -o /home/Oxyde/gnome/js185-1.0.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 6020k  100 6020k    0     0   110k      0  0:00:54  0:00:54 --:--:--  129k
gunzip -dc "/home/Oxyde/gnome/js185-1.0.0.tar.gz" | tar xf -
*** Applying patch js185-build.patch *** [1/1]
patch -p0 < "/home/Oxyde/gnome/jhbuild/patches/js185-build.patch"
patching file configure
patching file Makefile
*** Building js185 *** [1/1]
make  V=1
cd js/src && make
make[1]: Entering directory `/home/Oxyde/gnome/js185/js/src'
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory `/home/Oxyde/gnome/js185/js/src'
make: *** [all] Error 2
*** Error during phase build of js185: ########## Error running make  V=1 *** [1/1]
Comment 3 Colin Walters 2011-05-18 17:23:34 UTC
Created attachment 188058 [details] [review]
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs

Fix build without -a
Comment 4 Frederic Peters 2011-05-18 17:27:39 UTC
Perhaps you could try using the source-subdir attribute (of <branch>), instead of adding a fake configure.
Comment 5 Colin Walters 2011-05-18 17:53:19 UTC
Created attachment 188060 [details] [review]
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs

Use source-subdir
Comment 6 Craig Keogh 2011-05-19 02:30:55 UTC
Comment on attachment 188060 [details] [review]
gnome-suites-core-deps-3.2: Switch over to js185 release for gjs

Thank you for the patch. Committed. I changed checkoutdir="js185-1.0.0" to support a possible js185-1.0.1 in the future.

http://git.gnome.org/browse/jhbuild/commit/?id=17c065be6d063c1cee9183bc149743cff4c3b905