After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650418 - menu: don't use the border as a padding value
menu: don't use the border as a padding value
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-05-17 18:22 UTC by Cosimo Cecchi
Modified: 2011-05-18 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
menu: don't use the border as a padding value (22.04 KB, patch)
2011-05-17 18:22 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-05-17 18:22:28 UTC 
This is basically a follow-up of commits bb038d4dd4c6cd031b433ce68d1c00069194ed06 and b1d08fe0e9b79939847b1a072284bff6d26bffd7 for GtkMenu and GtkMenuItem.
Comment 1 Cosimo Cecchi 2011-05-17 18:22:31 UTC 
Created attachment 187979 [details] [review]
menu: don't use the border as a padding value

Borders should be rendered inside the allocation, not act as a second
padding.
Comment 2 Matthias Clasen 2011-05-18 14:15:12 UTC 
See my comment on the treeview bug regarding the need to define these theme drawing rules somewhere. As for the patch itself, if it doesn't break things in Adwaita or Raleigh, no objections.
Comment 3 Cosimo Cecchi 2011-05-18 14:49:28 UTC 
The default CSS actually had a workaround to reset the menu padding, which can now be removed.
I pushed this patch to master, plus the tweak to the default CSS to keep on drawing menus correctly.

Attachment 187979 [details] pushed as 091a4d7 - menu: don't use the border as a padding value