After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650329 - ClutterModifierType: Port fix from GDK to clutter's GDK copy
ClutterModifierType: Port fix from GDK to clutter's GDK copy
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-16 16:46 UTC by Colin Walters
Modified: 2011-06-13 23:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ClutterModifierType: Port fix from GDK to clutter's GDK copy (2.36 KB, patch)
2011-05-16 16:47 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2011-05-16 16:46:59 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=634994 where GDK was
modified to include all flag values, which helps bindings.  Port this
fix to Clutter's copy of GDK.
Comment 1 Colin Walters 2011-05-16 16:47:01 UTC 
Created attachment 187922 [details] [review]
ClutterModifierType: Port fix from GDK to clutter's GDK copy
Comment 2 Dan Winship 2011-05-16 18:41:36 UTC 
an alternate fix would be to just always mask return values with CLUTTER_MODIFIER_MASK and declare that the XKB, etc, bits are not part of the Clutter API. (That would be fine for the shell's purposes.)
Comment 3 Colin Walters 2011-05-16 18:46:51 UTC 
(In reply to comment #2)
> an alternate fix would be to just always mask return values with
> CLUTTER_MODIFIER_MASK and declare that the XKB, etc, bits are not part of the
> Clutter API. (That would be fine for the shell's purposes.)

I thought we rely on symmetry with GdkModifierType, so we couldn't do that.  

In any case it makes sense to keep the copies in sync, and the "just declare the values" approach works well (I tested it).
Comment 4 Emmanuele Bassi (:ebassi) 2011-05-20 10:54:24 UTC 
Review of attachment 187922 [details] [review]:

looks good. and yes, we kind of rely on the same semantics as GdkModifierType: the ClutterModifierType shuld map 1:1 to the bits set inside the XEvents with a state field.
Comment 5 Emmanuele Bassi (:ebassi) 2011-06-13 23:06:16 UTC 
Attachment 187922 [details] pushed as b046bc3 - ClutterModifierType: Port fix from GDK to clutter's GDK copy