GNOME Bugzilla – Bug 650292
Toolbar unlock button looks out of place
Last modified: 2011-07-12 13:43:55 UTC
The current design pattern is to put the unlock in the bottom left corner of a panel. This isn't great, since it breaks hierarchy: if something affects something else, it should be on top of it. :) Moving unlock buttons to the toolbar would solve this problem (mockup attached). It would also save us some vertical screen space.
Created attachment 187891 [details] Mockup of the user accounts panel with the unlock button in the toolbar
I very much agree. It also makes the button easier to find and saves a lot of vertical space.
This will take some re-shuffling, since the lock button is currently part of the pages; to move it out, we'll have to add some api to the modules that lets them provide a permission object to the shell, or something.
Created attachment 188264 [details] [review] 0001-Add-a-cc_panel_get_permission-method.patch
Created attachment 188265 [details] [review] 0002-Add-a-lockbutton-to-the-toolbar.patch
Created attachment 188266 [details] [review] 0003-Printers-Don-t-add-a-lockbutton.patch
Created attachment 188267 [details] [review] 0004-Datetime-Don-t-add-a-lockbutton.patch
Created attachment 188268 [details] [review] 0005-users-don-t-add-a-lockbutton.patch
Doesn't seem to work here. I get warnings: (gnome-control-center:10633): Gtk-CRITICAL **: gtk_lock_button_set_permission: assertion `G_IS_PERMISSION (permission)' failed And the button doesn't show up when I go to the date & time. It seems to show up as an icon and a separate label in the toolbar as well (rather than being a single button/toolbar item).
(In reply to comment #9) > Doesn't seem to work here. I get warnings: > (gnome-control-center:10633): Gtk-CRITICAL **: gtk_lock_button_set_permission: > assertion `G_IS_PERMISSION (permission)' failed Yeah, I've only recently allowed this in GTK+. So you need to run against a recent gtk master. > And the button doesn't show up when I go to the date & time. It seems to show > up as an icon and a separate label in the toolbar as well (rather than being a > single button/toolbar item). This sounds curious. Might be a theme issue, too. Screenshot ?
(In reply to comment #10) > (In reply to comment #9) > > Doesn't seem to work here. I get warnings: > > (gnome-control-center:10633): Gtk-CRITICAL **: gtk_lock_button_set_permission: > > assertion `G_IS_PERMISSION (permission)' failed > > Yeah, I've only recently allowed this in GTK+. So you need to run against a > recent gtk master. Need to up the GTK+ dep here then. > > And the button doesn't show up when I go to the date & time. It seems to show > > up as an icon and a separate label in the toolbar as well (rather than being a > > single button/toolbar item). > > This sounds curious. Might be a theme issue, too. Screenshot ? As discussed on IRC, that's how the GtkLockButton works. We should probably talk to designers to get that handled, but looks good to me, so feel free to commit, and we can handle the look afterwards.
> As discussed on IRC, that's how the GtkLockButton works. We should probably > talk to designers to get that handled, but looks good to me, so feel free to > commit, and we can handle the look afterwards. Yes, talking to them now. I'll commit this soon, thanks.
Leaving open for the lock button design discussion.
The lock button has been redesigned to look like a regular button, so I think this can be closed now.