After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650268 - build failure: "--vapidir=.: command not found"
build failure: "--vapidir=.: command not found"
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
0.5.x
Other Linux
: Normal critical
: Unset
Assigned To: folks-maint
folks-maint
: 650552 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-05-15 23:49 UTC by David Ronis
Modified: 2011-06-01 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Only build the VAPI files if vala is available. (8.16 KB, patch)
2011-06-01 06:04 UTC, Travis Reitter
none Details | Review
Pseudo-release tarball to test the fix (923.95 KB, application/x-bzip)
2011-06-01 06:05 UTC, Travis Reitter
  Details

Description David Ronis 2011-05-15 23:49:08 UTC
I just tried upgrading from 0.5.0 to 0.5.1.   The build dies with:

make[6]: Leaving directory `/home/ronis/Project/notar/GNOME/garnome/desktop/folks/work/main.d/folks-0.5.1/backends/telepathy/lib'
  GEN    tp-lowlevel.vapi
/bin/sh: --vapidir=.: command not found
make[5]: *** [tp-lowlevel.vapi] Error 127

Looks like some makefile generation didn't work.
Comment 1 André Klapper 2011-05-16 06:16:56 UTC
Confirming; running jhbuild with custom moduleset definitions.
Comment 2 Travis Reitter 2011-05-17 05:01:50 UTC
(In reply to comment #0)
> I just tried upgrading from 0.5.0 to 0.5.1.   The build dies with:
> 
> make[6]: Leaving directory
> `/home/ronis/Project/notar/GNOME/garnome/desktop/folks/work/main.d/folks-0.5.1/backends/telepathy/lib'
>   GEN    tp-lowlevel.vapi
> /bin/sh: --vapidir=.: command not found
> make[5]: *** [tp-lowlevel.vapi] Error 127
> 
> Looks like some makefile generation didn't work.

This means Folks was configured such that it depends upon Vala (eg, you set --enable-vala or --enable-inspect-tool). But it should have been caught at configure time.

We make our release tarballs such that gobject-introspection and Vala shouldn't be necessary to build them (and I uninstall both and build the release tarball during release testing, which should cover this case). Are you building this from the release tarball or from the git tag for 0.5.1?

What configure options are you using? Could you include the full output of configure?
Comment 3 Philip Withnall 2011-05-19 16:39:35 UTC
*** Bug 650552 has been marked as a duplicate of this bug. ***
Comment 4 Guillaume Desmottes 2011-05-20 07:46:52 UTC
> What configure options are you using? Could you include the full output of
> configure?

I attached the full build log on the bug; see bug #650552
Comment 5 Travis Reitter 2011-05-31 16:59:24 UTC
(In reply to comment #4)
> > What configure options are you using? Could you include the full output of
> > configure?
> 
> I attached the full build log on the bug; see bug #650552

Based on this log, it's trying to generate tp-lowlevel.vapi (and tp-lowlevel.gir, though it appears you have gobject-introspection installed). However, that file and its associated stamp file are included in the release tarball. I uninstalled both gobject-introspection and the vala tools and could not reproduce your problem.

These files are removed by "make maintainer-clean", but then you would hit a configure-time error due to Vala being missing. And you shouldn't need to run maintainer-clean in a release tarball anyhow.

Could you please try this again with a fresh release tarball? It shouldn't matter, but I don't see any other way that you could have gotten to this state other than manually removing specific files.
Comment 6 David Ronis 2011-05-31 17:36:07 UTC
I downloaded a fresh tarball.   The problem remains.
Comment 7 Travis Reitter 2011-06-01 06:02:18 UTC
So, I still haven't reproduce the problem, but I think I see its source:

tp-lowlevel.vapi depends upon tp-lowlevel.gir depends upon libtp-lowlevel.la

libtp-lowlevel.la always gets built in the release tarball, causing the gir file to be rebuilt, then the vapi file (which can't be built if vala/vapigen isn't installed). What I don't understand is why I never hit this bug. Even if I remove my Vala install before building, I don't hit this bug.

At any rate, this new patch should fix the problem. Please try building from the tarball.
Comment 8 Travis Reitter 2011-06-01 06:04:04 UTC
Created attachment 188968 [details] [review]
Only build the VAPI files if vala is available.

Patches from branch:

http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo650268-valaless-failure
Comment 9 Travis Reitter 2011-06-01 06:05:23 UTC
Created attachment 188970 [details]
Pseudo-release tarball to test the fix
Comment 10 Guillaume Desmottes 2011-06-01 08:12:31 UTC
Seems to works fine here!
Comment 11 David Ronis 2011-06-01 15:17:25 UTC
Works here too.
Comment 12 Travis Reitter 2011-06-01 16:13:00 UTC
Fixed with the following commit. I'll be releasing 0.5.2 shortly; please re-test with that just to be sure.

commit 1ab93eb1b5714781eefb5ee897f2b167c510054b
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Tue May 31 16:21:33 2011 -0700

    Don't re-build the vapi files unless we've been configured with Vala.

 backends/telepathy/lib/Makefile.am          |    2 ++
 tests/lib/telepathy/contactlist/Makefile.am |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)
Comment 13 Travis Reitter 2011-06-01 18:15:42 UTC
New tarball released (0.5.2) - please verify one last time: http://ftp.gnome.org/pub/GNOME/sources/folks/0.5/
Comment 14 David Ronis 2011-06-01 18:28:50 UTC
It compiled/installed fine.  Thanks