After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650209 - Add Standard ML lang
Add Standard ML lang
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-15 03:07 UTC by mh512
Modified: 2011-06-18 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for Standard ML lang (8.19 KB, patch)
2011-05-15 03:07 UTC, mh512 		needs-work Details | Review
Patch for Standard ML lang (v2) (8.16 KB, patch)
2011-05-15 16:20 UTC, mh512 		none Details | Review

Description mh512 2011-05-15 03:07:00 UTC 
Created attachment 187831 [details] [review]
Patch for Standard ML lang

New language definition for Standard ML.
Patch attached.
Comment 1 Ignacio Casal Quinteiro (nacho) 2011-05-15 09:00:23 UTC 
Review of attachment 187831 [details] [review]:

The Lang file looks very good, just one thing. Right now we are creating the main context separately and adding ref inside the other context. See the prolog.lang to see how to update yours.
Comment 2 mh512 2011-05-15 16:20:15 UTC 
Created attachment 187852 [details] [review]
Patch for Standard ML lang (v2)

Re-organized context as per prolog.lang
Comment 3 Paolo Borelli 2011-06-18 14:11:02 UTC 
Thanks. I committed the file in git. I only removed the mimetype lines since it is not a mandatory metadata and we only accept mimetypes that are included and in freedesktop's shared-mime-info database.