After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650184 - Importing a xspf-playlist has no effect at all
Importing a xspf-playlist has no effect at all
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
2.0.0
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-14 14:55 UTC by Matthias Kubisch
Modified: 2011-08-18 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for this bug (1.64 KB, patch)
2011-06-16 23:26 UTC, Johannes Koch (Snorri)
none Details | Review
the banshee log file (139.10 KB, text/plain)
2011-06-17 11:21 UTC, Johannes Koch (Snorri)
  Details

Description Matthias Kubisch 2011-05-14 14:55:57 UTC
simply nothing happens... the list was previously exported by banshee of the same version but on a different computer... but music-file structure was the same.
Comment 1 Victor Vargas 2011-06-01 20:39:18 UTC
Same issue here with banshee 2.0 in Ubuntu Natty Narwhal, banshee debug is at https://launchpadlibrarian.net/72815675/log
Comment 2 Johannes Koch (Snorri) 2011-06-16 23:26:19 UTC
Created attachment 190082 [details] [review]
Fix for this bug

Mono.Media: Fix Xspf Playlist importing Error (bgo#650184) (LP#791418)

This fix parses the date tag of an xspf file in the right way.
It converts the millisecond value regardless of culture into a short integer.

In some configurations the parser removed the leading point.
Therefore, the result was an high integer value, which caused an ArgumentOutOfRangeException.
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2011-06-17 11:08:53 UTC
(In reply to comment #2)
> Created an attachment (id=190082) [details] [review]
> Fix for this bug
> 
> Mono.Media: Fix Xspf Playlist importing Error (bgo#650184) (LP#791418)
> 
> This fix parses the date tag of an xspf file in the right way.
> It converts the millisecond value regardless of culture into a short integer.
> 
> In some configurations the parser removed the leading point.
> Therefore, the result was an high integer value, which caused an
> ArgumentOutOfRangeException.

Hey Snorri thanks for the patch, looks good!

For the record, can you attach also the log that banshee generates (where it sends the ArgumentOutOfRangeException) when this fix is not in place?

Also: knowing your complete name (instead of just an alias) would be good, to put you in the list of contributors.
Comment 4 Johannes Koch (Snorri) 2011-06-17 11:21:15 UTC
Created attachment 190105 [details]
the banshee log file

last entry is interesting for this section
Comment 5 olivier dufour 2011-08-18 21:33:45 UTC
Fix style (no more than 120 char on a line) and commit your patch.
Thanks for patch.