After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650169 - register EVCardAttribute as a Boxed Type so it can be introspected
register EVCardAttribute as a Boxed Type so it can be introspected
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.2.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-05-14 11:49 UTC by Raul Gutierrez Segales
Modified: 2013-09-14 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Register EVCardAttribute as a boxed type (2.42 KB, patch)
2011-05-14 11:49 UTC, Raul Gutierrez Segales
accepted-commit_now Details | Review
Register EVCardAttributeParam as a boxed type too (2.30 KB, patch)
2011-05-14 12:24 UTC, Raul Gutierrez Segales
accepted-commit_now Details | Review

Description Raul Gutierrez Segales 2011-05-14 11:49:15 UTC
Created attachment 187807 [details] [review]
Register EVCardAttribute as a boxed type

The attached patch registers EVCardAttribute as a Boxed Type. Without it, g-ir-scanner complains about not knowing how to deal with e_vcard_attribute_new and it'll probably be hard (if not impossible) to use it from a dynamic binding. 

Also, EVCardAttribute will sure be needed by applications trying to write back to libebook via an introspected binding.

If it looks good I'll go ahead and push it to master (I've got commit access now).
Comment 1 Raul Gutierrez Segales 2011-05-14 12:24:29 UTC
Created attachment 187809 [details] [review]
Register EVCardAttributeParam as a boxed type too

This is also needed to make g-ir-scanner happy.
Comment 2 Matthew Barnes 2011-05-16 13:15:44 UTC
Both patches look fine, feel free to commit them.
Comment 3 Raul Gutierrez Segales 2011-05-16 13:24:21 UTC
Merged:

commit 2263b4f4a58b2d3a62055138d5e085e3f4f4c3bb
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Sat May 14 13:22:45 2011 +0100

    Register EVCardAttributeParam as a boxed type
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=650169

commit 3c1205d85adee9063252bd747dc7d554b9feeea9
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Sat May 14 12:33:25 2011 +0100

    Register EVCardAttribute as a boxed type
    
    Without this EVCardAttribute can't be picked up by
    g-ir-scanner when trying to generate the GIR file for
    libebook.
    
    Also, EVCardAttribute will need to be used by applications
    trying to write back to libebook via an introspected binding.
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=650169