After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650044 - info: Implement setting of "PrettyHostname" property
info: Implement setting of "PrettyHostname" property
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-12 14:15 UTC by Bastien Nocera
Modified: 2011-05-13 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
info: Implement setting of "PrettyHostname" property (12.02 KB, patch)
2011-05-12 14:15 UTC, Bastien Nocera
needs-work Details | Review
pretty hostname (89.91 KB, image/png)
2011-05-12 14:30 UTC, Bastien Nocera
  Details
additional hostname settings (28.39 KB, image/png)
2011-05-12 14:30 UTC, Bastien Nocera
  Details
aligned items (36.79 KB, image/png)
2011-05-12 16:40 UTC, Bastien Nocera
  Details
not aligned (36.15 KB, image/png)
2011-05-12 16:41 UTC, Bastien Nocera
  Details

Description Bastien Nocera 2011-05-12 14:15:08 UTC
First pass.

Missing:
- updating the static hostname when the pretty hostname changes
- fixing the padding when a button is shown (eg. the user is an admin)
Comment 1 Bastien Nocera 2011-05-12 14:15:10 UTC
Created attachment 187710 [details] [review]
info: Implement setting of "PrettyHostname" property

This property can be used to name services running on the machine
such as media sharing, device sharing, or externally visible
services such as the Bluetooth name.
Comment 2 Bastien Nocera 2011-05-12 14:19:10 UTC
The changes require this change in systemd:
http://cgit.freedesktop.org/systemd/commit/?id=88a07670cfa974a605c7c7b520b8a3135fce37f9

You can test this by adding "org.freedesktop.hostname1.set-static-hostname" to your /var/lib/polkit-1/localauthority/10-vendor.d/10-desktop-policy.pkla (or "org.freedesktop.hostname1.set-machine-info" with an older systemd).
Comment 3 Bastien Nocera 2011-05-12 14:21:36 UTC
We'd also need some design for how/where to show the "static hostname" when changed. Maybe we should have this code in the network panel instead?
Comment 4 Bastien Nocera 2011-05-12 14:30:14 UTC
Created attachment 187711 [details]
pretty hostname

Pretty hostname on OSX
Comment 5 Bastien Nocera 2011-05-12 14:30:43 UTC
Created attachment 187712 [details]
additional hostname settings

From OSX as well.
Comment 6 Bastien Nocera 2011-05-12 14:59:42 UTC
Discussed with lapo and lennart. We won't be showing the "hostname" of the machine for now. If we do end up showing it, it would probably be in the network panel.
Comment 7 Bastien Nocera 2011-05-12 16:40:49 UTC
Created attachment 187722 [details]
aligned items

Items aligned by using the same "editable entry" for all the items. Too much vertical space used (especially when the dialogue was already too big for netbooks)
Comment 8 Bastien Nocera 2011-05-12 16:41:35 UTC
Created attachment 187723 [details]
not aligned

And not aligned. The device name is the only one with an "editable entry" being used.
Comment 9 Bastien Nocera 2011-05-13 12:38:00 UTC
commit a089d7e710e652693898cb17cde29f4eb266e994
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu May 12 14:46:50 2011 +0100

    info: Implement setting of "PrettyHostname"
    
    This property can be used to name services running on the machine
    such as media sharing, device sharing, or externally visible
    services such as the Bluetooth name.
    
    We don't set the statis hostname yet though, this will need
    to be done to follow the recommendations from systemd.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=650044
Comment 10 Bastien Nocera 2011-05-13 15:09:14 UTC
commit 018848689070c3dae16eb4d6ee6046764be32129
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri May 13 16:07:55 2011 +0100

    info: Set the StaticHostname
    
    when changing the PrettyHostname
    
    https://bugzilla.gnome.org/show_bug.cgi?id=650044

commit a2885a56d41f5f190bc3d5ad1dab8e43088457a9
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri May 13 15:48:45 2011 +0100

    info: Add helper for pretty hostname to hostname
    
    So that we can set the static hostname depending on the value
    of the pretty hostname.