After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649989 - Split GcrSelector into GcrComboSelector and GcrTreeSelector
Split GcrSelector into GcrComboSelector and GcrTreeSelector
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-05-11 19:29 UTC by Stef Walter
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Split GcrSelector into GcrComboSelector and GcrTreeSelector (121.01 KB, patch)
2011-05-11 19:47 UTC, Stef Walter 		none Details | Review

Description Stef Walter 2011-05-11 19:29:23 UTC 
GcrSelector (merged into 3.1.x) has a single and multiple mode, which caused essentially completely different widgets. This is confusing and hard to maintain.

Change it around so we have different widgets:

     * GcrComboSelector allows selecting one object at a time
       and uses 'markup' property to display the object.
     * GcrTreeSelector uses various columns, and a checkbox so that multiple
       objects can be selected at once.
     * Add images for both of the above.
     * Derive directly from GtkComboBox and GtkTreeView respectively.
Comment 1 Stef Walter 2011-05-11 19:47:26 UTC 
Created attachment 187659 [details] [review]
Split GcrSelector into GcrComboSelector and GcrTreeSelector

Branch here: http://cgit.collabora.co.uk/git/user/stefw/gnome-keyring.git/log/?h=split-selector
Comment 2 Stef Walter 2011-05-24 07:31:24 UTC 
Merged with master.