After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649966 - lightsoff: Partial port to python
lightsoff: Partial port to python
Status: RESOLVED OBSOLETE
Product: gnome-games-superseded
Classification: Deprecated
Component: lightsoff
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
Robert Carr
Depends on:
Blocks:
 
 
Reported: 2011-05-11 13:43 UTC by Colin Walters
Modified: 2011-12-17 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lightsoff: Partial port to python (69.88 KB, patch)
2011-05-11 13:43 UTC, Colin Walters
none Details | Review
lightsoff: Remove (for now) (309.15 KB, patch)
2011-05-11 14:01 UTC, Colin Walters
none Details | Review
Move lightsoff and swell-foop to staging (1.20 KB, patch)
2011-05-11 19:24 UTC, Colin Walters
none Details | Review

Description Colin Walters 2011-05-11 13:43:34 UTC
At least two days of work here; shelving for now.
Comment 1 Colin Walters 2011-05-11 13:43:37 UTC
Created attachment 187628 [details] [review]
lightsoff: Partial port to python
Comment 2 Colin Walters 2011-05-11 14:01:55 UTC
Created attachment 187631 [details] [review]
lightsoff: Remove (for now)

We want to deprecate seed and gjs as application development
platforms, and since lightsoff is just a game, it's easy enough
to drop it for now.  See http://mail.gnome.org/archives/desktop-devel-list/2011-April/msg00147.html
Comment 3 Thomas Andersen 2011-05-11 14:17:49 UTC
I wish you would have coordinated this work with us on the mailing list. Gnome games actually has a long term plan to move C and vala only. Chess was even ported from python to vala last cycle.
Comment 4 Colin Walters 2011-05-11 14:40:30 UTC
(In reply to comment #3)
> I wish you would have coordinated this work with us on the mailing list. 

Ok, sorry.  

> Gnome
> games actually has a long term plan to move C and vala only. Chess was even
> ported from python to vala last cycle.

I see, sounds good.  Anyways - can we remove/disable it by default for now?
Comment 5 Thomas Andersen 2011-05-11 14:44:05 UTC
Do you want to avoid having it in the 3.0.2 release or 3.1.2?

I don't think there is any reason to remove it yet but we can easily disable it.
Comment 6 Colin Walters 2011-05-11 15:38:23 UTC
(In reply to comment #5)
> Do you want to avoid having it in the 3.0.2 release or 3.1.2?

It's not urgent, whichever is easier.
 
> I don't think there is any reason to remove it yet but we can easily disable
> it.

The code will always be around in the git history, so I don't see a big difference between removing it from the configure options and deleting the code; but if you prefer disabling it that's fine by me, I can make a new patch.
Comment 7 Robert Ancell 2011-05-11 16:08:21 UTC
What is the exact point of this change?

The facts:
- We have two games written in Javascript (lightsoff and swell-foop), using the seed interpreter.
- I think it's fair to say Javascript was chosen for these games on the basis it was a good future language to use.  GNOME Games was an early adopter and these games were somewhat expiremental.
- Javascript has not been widely adopted in the GNOME project and the interpreter used is not the same as the one used in GNOME Shell (gjs).
- Colin has done some work to convert lightsoff to Python
- The GNOME games project has a long term plan to consolidate languages used, and was in the process of dropping Python.

So, we have some options:
1. Port both games to another language
2. Keep distributing these games as is
3. Disable these games

Doing option 1 would be great, as this helps in the effort to consolidate GNOME Games languages.  It would require some work, and as these games are recently written and in reasonable shape it seems lower priority than working on other games.  They're not well maintained so it would be nice for the rewriter to help in maintaining them.

I don't see any reason to disable the games however.  I don't see any difficulty in distributors choosing if they want to use them or not.  Does disabling them affect anyone?
Comment 8 Thomas Andersen 2011-05-11 16:47:49 UTC
If it helps to make the message more clear that GNOME does not encourage javascript for applications then I think we should go for 3 now. Distributions can reenable it if they choose.
Comment 9 Colin Walters 2011-05-11 19:24:51 UTC
Created attachment 187658 [details] [review]
Move lightsoff and swell-foop to staging

We want to deprecate seed and gjs as application development
platforms, and since lightsoff is just a game, it's easy enough
to drop it for now.  See http://mail.gnome.org/archives/desktop-devel-list/2011-April/msg00147.html
Comment 10 Robert Ancell 2011-12-17 12:07:34 UTC
LightsOff is now in Vala (bug 664410).   Sorry for the duplicate work Colin.