GNOME Bugzilla – Bug 649936
[patch] add an explicit option for libcap-ng
Last modified: 2019-02-22 11:46:08 UTC
The attached patch adds an explicit option to enable/disable libcap-ng support. The default behaviour is to auto-detect as previously, though you can do with --with-libcap-ng or --without-libcap-ng to enable/disable it explicitly.
Created attachment 187607 [details] [review] 0001-optionalise-libcap-ng-check.patch
Created attachment 188254 [details] [review] improved patch for 3.1.x Saleem Abdulrasool's patch works, but contains a logic error: given the lines with_libcap_ng="no" if test x"$with_libcap_ng" = x"yes" ; then [...] the if will clearly never be run :) I am attaching a modification of Saleem's patch that moves the with_libcap_ng="no" below the if statement (and adds an AC_MSG_WARN for the with_libcap_ng="auto" case when libcap-ng cannot be found).
Created attachment 188258 [details] [review] patch for 3.0.x And here is a version of the same patch for the 3.0.x branch of gnome-keyring (uses libcap2 instead of libcap-ng).
Tomas, or Steve can you review this patch?
Created attachment 195651 [details] [review] 0001-optionalise-libcap-ng-check.patch updated the patch; can I get an okay to push this please?
Merged the last patch into gnome-keyring into master, which will become part of 3.1.91. Put the bugzilla URL in the commit message.