After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649936 - [patch] add an explicit option for libcap-ng
[patch] add an explicit option for libcap-ng
Status: RESOLVED FIXED
Product: libgnome-keyring
Classification: Core
Component: General
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-05-11 06:28 UTC by Saleem Abdulrasool
Modified: 2019-02-22 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-optionalise-libcap-ng-check.patch (1.84 KB, patch)
2011-05-11 06:29 UTC, Saleem Abdulrasool
none Details | Review
improved patch for 3.1.x (2.15 KB, patch)
2011-05-20 22:12 UTC, Alexandre Rostovtsev
none Details | Review
patch for 3.0.x (1.91 KB, patch)
2011-05-20 23:06 UTC, Alexandre Rostovtsev
none Details | Review
0001-optionalise-libcap-ng-check.patch (1.93 KB, patch)
2011-09-05 02:35 UTC, Saleem Abdulrasool
none Details | Review

Description Saleem Abdulrasool 2011-05-11 06:28:43 UTC
The attached patch adds an explicit option to enable/disable libcap-ng support.  The default behaviour is to auto-detect as previously, though you can do with --with-libcap-ng or --without-libcap-ng to enable/disable it explicitly.
Comment 1 Saleem Abdulrasool 2011-05-11 06:29:10 UTC
Created attachment 187607 [details] [review]
0001-optionalise-libcap-ng-check.patch
Comment 2 Alexandre Rostovtsev 2011-05-20 22:12:02 UTC
Created attachment 188254 [details] [review]
improved patch for 3.1.x

Saleem Abdulrasool's patch works, but contains a logic error: given the lines

with_libcap_ng="no"
if test x"$with_libcap_ng" = x"yes" ; then
[...]

the if will clearly never be run :)

I am attaching a modification of Saleem's patch that moves the with_libcap_ng="no" below the if statement (and adds an AC_MSG_WARN for the with_libcap_ng="auto" case when libcap-ng cannot be found).
Comment 3 Alexandre Rostovtsev 2011-05-20 23:06:09 UTC
Created attachment 188258 [details] [review]
patch for 3.0.x

And here is a version of the same patch for the 3.0.x branch of gnome-keyring (uses libcap2 instead of libcap-ng).
Comment 4 Stef Walter 2011-05-22 10:47:53 UTC
Tomas, or Steve can you review this patch?
Comment 5 Saleem Abdulrasool 2011-09-05 02:35:37 UTC
Created attachment 195651 [details] [review]
0001-optionalise-libcap-ng-check.patch

updated the patch; can I get an okay to push this please?
Comment 6 Stef Walter 2011-09-05 05:39:14 UTC
Merged the last patch into gnome-keyring into master, which will become part of 3.1.91. Put the bugzilla URL in the commit message.