After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649790 - Vala uses the wrong includes
Vala uses the wrong includes
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-09 12:42 UTC by Alexander Larsson
Modified: 2011-05-11 06:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure includes are done with <folks/*.h> (5.40 KB, patch)
2011-05-10 11:12 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Alexander Larsson 2011-05-09 12:42:13 UTC 
The vapi file for folks claims the include header is "folks.h", but its really "folks/folks.h", since the pc file doesn't include -I $include/folks.

The fix is simple:

diff --git a/folks/Makefile.am b/folks/Makefile.am
index cc6db7b..17e1928 100644
--- a/folks/Makefile.am
+++ b/folks/Makefile.am
@@ -52,6 +52,7 @@ libfolks_la_VALAFLAGS = \
        --pkg gio-2.0 \
        --pkg gee-1.0 \
        --pkg gconf-2.0 \
+       --includedir folks \
        --vapi folks.vapi \
        -H folks.h \
        $(NULL)
Comment 1 Philip Withnall 2011-05-09 21:03:16 UTC 
Looks good to me. Could you make corresponding changes in all the backends/*/lib directories, remove “-I${includedir}/folks” from their .pc files, add a note about the changes in NEWS and post an updated patch here please?
Comment 2 Alexander Larsson 2011-05-10 11:12:37 UTC 
Created attachment 187568 [details] [review]
Ensure includes are done with <folks/*.h>

This changes all pc files to not include -I$incdir/folks and fixes
the vapi files to add the folks/ part to the includes.
Comment 3 Philip Withnall 2011-05-10 21:46:32 UTC 
Review of attachment 187568 [details] [review]:

Looks good. Please commit to master.
Comment 4 Alexander Larsson 2011-05-11 06:44:52 UTC 
pushed