After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649783 - Make sure all lines are ellipsized
Make sure all lines are ellipsized
Status: RESOLVED OBSOLETE
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-09 11:32 UTC by Benjamin Otte (Company)
Modified: 2018-05-22 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
layout: Make sure all lines are ellipsized (1.17 KB, patch)
2011-05-09 11:32 UTC, Benjamin Otte (Company)
none Details | Review

Description Benjamin Otte (Company) 2011-05-09 11:32:11 UTC
All lines that are too long should be ellipsized when ellipsizing is
enabled. Not just those lines where we thought they'd need to be in
advance. It might turn out that a word is too long so that we cannot
wrap it. In that case we still want to break as soon as possible, but
still ellipsize the line.
Comment 1 Benjamin Otte (Company) 2011-05-09 11:32:14 UTC
Created attachment 187498 [details] [review]
layout: Make sure all lines are ellipsized
Comment 2 Benjamin Otte (Company) 2011-05-09 11:54:24 UTC
This is tested by GTK's tests/reftest/label-sizing.ui reftest btw, which currently fails. So either we need to adapt the reftest to current Pango behavior so distcheck actually starts passing, or we need this to get fixed rather quickly.

Or Matthias is going to pitchfork me for breaking distcheck. :)
Comment 3 Behdad Esfahbod 2011-05-10 01:04:45 UTC
Can you suggest test case using pango-view?
Comment 4 Benjamin Otte (Company) 2011-05-10 17:44:54 UTC
pango-view --wrap=word --height=200 --width=100 --ellipsize=end -t "Supercalifragelisticexpialidocious is a long word."

is an obvious case. Pretty much everything is ok that matches

pango-view --wrap=word --ellipsize=end --height=$BIG --width=$SMALLER_AS_LARGEST_WORD
Comment 5 Matthias Clasen 2011-06-13 11:03:01 UTC
Any news on this ? make check still failing in gtk...
Comment 6 Behdad Esfahbod 2011-06-15 15:37:43 UTC
As discussed on #gtk+ today, the pango patch needs more consideration before it goes in, because it changes the semantics of the pango api.  We first need to define the desired behavior before any such change can be made.  I'll draft something and post for comments.  What should happen to the gtk test or implementation is out of my scope.
Comment 7 Benjamin Otte (Company) 2011-07-05 13:32:51 UTC
I've changed the gtk test now to mirror current Pango behavior. See http://git.gnome.org/browse/gtk+/commit/?id=ace4faa4e22ddfb6153e18c3f4c1dfc5f3ee8194 for the commit.
Comment 8 GNOME Infrastructure Team 2018-05-22 13:00:24 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/192.