Bug 649749 – glade_clipboard_get_has_selection not exported

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 649749 - glade_clipboard_get_has_selection not exported


Summary:	glade_clipboard_get_has_selection not exported


Status:	RESOLVED OBSOLETE

Product:	glade
Classification:	Applications
Component:	general
Version:	3.10.x
Hardware:	Other Windows

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Glade 3 Maintainers
QA Contact:	Glade 3 Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-05-08 16:57 UTC by Arnel Borja
Modified:	2013-08-17 12:43 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Patch to add a space after the name of the function glade_clipboard_get_has_selection (686 bytes, patch) 2011-05-08 16:57 UTC, Arnel Borja	none	Details \| Review

Description Arnel Borja 2011-05-08 16:57:47 UTC

Created attachment 187470 [details] [review]
Patch to add a space after the name of the function glade_clipboard_get_has_selection

The declaration of glade_clipboard_get_has_selection in glade-clipboard.h doesn't have a space between the function name and the opening parenthesis of the parameters. Because of this, the gladeui.def target in gladeui/Makefile.am skips the function, and it will not be exported.

This event causes a compilation error in Windows while compiling glade3.exe:
  CCLD   glade.exe
glade-glade-window.o:glade-window.c:(.text+0x48bb): undefined reference to `_glade_clipboard_get_has_selection'
glade-glade-window.o:glade-window.c:(.text+0x4d65): undefined reference to `_glade_clipboard_get_has_selection'
collect2: ld returned 1 exit status

The attachment will fix the bug the easier way: by adding a space after the function name. But I think a better way would be to change the filter in gladeui.def so cases like this will be caught, preventing additional bugs in the future, and there might be other cases like this that are still unnoticed.