After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649633 - shell-tp-client: enable client recovery
shell-tp-client: enable client recovery
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-07 07:40 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-05-12 01:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-tp-client: enable client recovery (935 bytes, patch)
2011-05-07 07:40 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-05-07 07:40:23 UTC 
If we don't do this, we won't ever see chats that already existed, even after
we get a new message from them (is that how observers are supposed to work?)
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-05-07 07:40:25 UTC 
Created attachment 187409 [details] [review]
shell-tp-client: enable client recovery

This makes sure that we get any channels that existed at the time the shell
started, otherwise some chats may never appear.
Comment 2 Guillaume Desmottes 2011-05-09 08:30:45 UTC 
Review of attachment 187409 [details] [review]:

Oh nice catch, I forgot it when doing the TpBaseClient port. Looks good to me but not changing the patch status as I'm not a Shell reviewer.
Comment 3 Colin Walters 2011-05-11 18:52:10 UTC 
Review of attachment 187409 [details] [review]:

Guillaume: If you have expertise in the area, that counts as reviewing =)
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-05-12 01:02:49 UTC 
Attachment 187409 [details] pushed as fb384fc - shell-tp-client: enable client recovery