GNOME Bugzilla – Bug 649621
A gnome shell extension to display distributor logo instead of 'Activities'
Last modified: 2013-05-24 15:30:33 UTC
Created attachment 187402 [details] [review] 0001-New-Extension-hotspot-icon.patch A simple extension that removes the text string 'Activities' and replaces with the distributors icon.
Review of attachment 187402 [details] [review]: ::: extensions/hotspot-icon/extension.js @@ +5,3 @@ + hotCornerButton = Main.panel.button; + + let logo = new St.Icon({ icon_type: St.IconType.FULLCOLOR, icon_size: hotCornerButton.height, icon_name: 'distributor' }); I would suggest using CSS (system-status-icon style class) instead of hardcoding the height (which is too big and overflows, btw) And 'distributor' is not a valid icon name on my system, it's 'start-here' @@ +7,3 @@ + let logo = new St.Icon({ icon_type: St.IconType.FULLCOLOR, icon_size: hotCornerButton.height, icon_name: 'distributor' }); + let box = new St.BoxLayout(); + box.add_actor(logo); Why the BoxLayout? @@ +9,3 @@ + box.add_actor(logo); + + Main.panel.button.set_child(box); You get better results if you add Main.panel.button.y_fill = true
In general I think it is a bit stupid to have the text "Actions". It reminds somewhat of the Windows "Start" but it does not closely give the appropriate credit to what Gnome Shell really is. Why not just show the Gnome logo there? If Gnome ever late gets other parallel items to Actions, like Places or something, then the text can be re-introduced, but at the moment just "Actions" seems weird.
Note that currently, extensions get loaded after a few frames have been rendered, so the user will see the 'Activities' text before it changes to the icon (see bug 699981).
Giovanni, is this something you want to add to gnome-shell-extensions, or should we refer this to extensions.gnome.org?
I believe that extensions.gnome.org is a more suitable place to host and distribute this. gnome-shell-extensions is a core module, and additions to it should happen for classic mode only.