After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649566 - Incorrect uses of the gtkSwitch widget
Incorrect uses of the gtkSwitch widget
Status: RESOLVED WONTFIX
Product: gnome-control-center
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-06 13:28 UTC by Jean-François Fortin Tam
Modified: 2011-08-26 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2011-05-06 13:28:39 UTC
From bug #644657 and the discussions that happened around it, my understanding of the acceptable use of a gtkSwitch widget is for things that toggle hardware on/off, and it is not acceptable for simply toggling boolean settings, which would be better served by a checkbox widget.

Here is a proposed list of areas in gnome-control-center 3.0 where the gtkSwitch should be replaced by a checkbox:
- Screen lock: make the "Lock screen after:" label a checkbox label
- Bluetooth: the "visibility" setting (at least)
- User account: auto login
- Date and time: 24 hours mode
- System info: forced fallback mode

You may find others but I'm taking a reasonable/modest approach here instead of saying they should all be taken out indiscriminately :)
Comment 1 Allan Day 2011-05-16 09:00:09 UTC
(In reply to comment #0)
> From bug #644657 and the discussions that happened around it, my understanding
> of the acceptable use of a gtkSwitch widget is for things that toggle hardware
> on/off, and it is not acceptable for simply toggling boolean settings, which
> would be better served by a checkbox widget.

Hardware is one key case; so too are toggling specific 'services' or modes which modify the system in a major way [1].

> Here is a proposed list of areas in gnome-control-center 3.0 where the
> gtkSwitch should be replaced by a checkbox:
> - Screen lock: make the "Lock screen after:" label a checkbox label
> - Bluetooth: the "visibility" setting (at least)
> - User account: auto login
> - Date and time: 24 hours mode
> - System info: forced fallback mode
> 
> You may find others but I'm taking a reasonable/modest approach here instead of
> saying they should all be taken out indiscriminately :)

I agree about 24 hours mode (see bug 640059); the others seem to be within the guidelines.

Visibility might be on the border, I guess...

[1] http://live.gnome.org/Design/Whiteboards/SwitchGuidance
Comment 2 Jean-François Fortin Tam 2011-05-16 18:11:04 UTC
My criterion on which I based many of those things was that most of these things do not an immediately visible effect and only apply on the next login. As such, this "on/off" switch metaphor from the real world breaks down completely. It's a preference, not something that flips electric current flow.
Comment 3 Allan Day 2011-08-26 16:08:59 UTC
(In reply to comment #2)
> It's a preference, not something that flips electric current flow.

But I think that is the mental model we're alluding to. Auto login might not come into effect until the next time you login, for example, but the suggestion is that it is engaged from the moment you flip the switch. That's easier for people to understand.
Comment 4 Bastien Nocera 2011-08-26 17:35:54 UTC
As per Allan's comment, we believe that those uses are within the guidelines. The 24h mode got fixed in a separate bug.

(And the Visibility switch in Bluetooth does actually have "electrical" and instantaneous effects, fwiw).