GNOME Bugzilla – Bug 649511
Allow editing printer name and location
Last modified: 2011-05-27 13:16:19 UTC
Being able to correct the printer name and location would be a useful feature. Maybe this could be in the options, or simply use gtk text entry widgets instead of labels (for the name and location) in the pane on the right. Or perhaps the name can be edited by clicking the listview item (to toggle editing mode) like many apps do (that way you could keep the fancy label/text size).
The user-accounts panel has a cheap 'editable label' implementation that can be used here.
Yeah, I was thinking about this one too, since it would be consistent then.
Created attachment 187759 [details] [review] allow editing of printer's name and its location Hi, this patch allows users to edit printer's name and its location. It uses UmEditableEntry for it. I had to use it also for all other fields in the panel since it adds some padding in front of the text. This also causes a little bigger spaces between those fields in vertical direction. However there are still 2 other problems. These are due to the fact that we need to create new printer with the new name and copy all properties of the original printer to the new one (that's why the patch is so big). The first problem is that current version of cups-pk-helper doesn't allow us to create a printer without a PPD and thus we can not add a raw printer. The second problem is that it can not add new classes (unless I overlooked it somewhere). I have patches for the two cups-pk-helper problems and I'll file bugs for them in appropriate bugzilla today. Regards Marek
(In reply to comment #3) > The second problem is that it can not add new classes (unless I overlooked it > somewhere). Funny, I overlooked one small detail. New classes are created by adding members to them. I'll attach modified patch soon.
Created attachment 187763 [details] [review] the promised modification (it renames classes now as well)
I think we are going to move the editable entry to libcontrol-center soon anyway. Might as well wait for that.
You can remove your copy of UmEditableEntry, it's now CcEditableEntry in libgnome-control-center.
Created attachment 187768 [details] [review] the patch using CcEditableEntry I've modified it so that it uses the CcEditableEntry now.
Seems to work fine in quick testing here. But I wonder what it actually does, just rename the queue locally ? Because I was allowed to change the names of remote printers here in the office, which had me somewhat concerned.
Created attachment 187896 [details] [review] modified patch It could rename the queue because it created new queue with the new name and deleted the old one. But it can not delete the remote queue so it should appear in few minutes again. And it can create only local queues so the new queue is local copy of the original queue. I've added test for whether the given queue is discovered and also whether actual CUPS server is remote so the widget is insensitive in such case (+ similar thing for add queue, remove queue, pause, ...). Marek