After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649486 - replace uuid check with something more portable
replace uuid check with something more portable
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: build
git master
Other All
: Normal normal
: ---
Assigned To: Aurimas Černius
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-05 17:34 UTC by Jasper Lievisse Adriaanse
Modified: 2011-05-10 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use pkg-config to pickup uuid. (1.48 KB, patch)
2011-05-05 17:34 UTC, Jasper Lievisse Adriaanse 		none Details | Review
Use pkg-config to pickup uuid. (1.57 KB, patch)
2011-05-05 17:35 UTC, Jasper Lievisse Adriaanse 		needs-work Details | Review

Description Jasper Lievisse Adriaanse 2011-05-05 17:34:06 UTC 
Created attachment 187303 [details] [review]
Use pkg-config to pickup uuid.

There's a comment in configure.ac:
"check for the ext2 uuid library. TODO replace it with something more portable"

The attached diff ought to do the trick by using pkg-config to search for the cflags and libs needed.
Comment 1 Jasper Lievisse Adriaanse 2011-05-05 17:35:31 UTC 
Created attachment 187304 [details] [review]
Use pkg-config to pickup uuid.
Comment 2 Aurimas Černius 2011-05-05 19:36:22 UTC 
Good work!
I'll do a deeper check soon.
Comment 3 Aurimas Černius 2011-05-08 14:28:27 UTC 
Review of attachment 187304 [details] [review]:

On Fedora 14 I found, that I could use pkg-config to find uuid, but it does not seem to work with e2fs-uuid:

pkg-config --list-all | grep uuid
uuid                                uuid - Universally unique id library

Do you can find uuid this way on OpenBSD?
Comment 4 Jasper Lievisse Adriaanse 2011-05-08 14:31:40 UTC 
The package that installs 'uuid.pc' on OpenBSD is the ossp-uuid. But I'm perfectly fine with patching the OpenBSD port to use 'e2fs-uuid.pc' and having upstream gnote use the more common 'uuid.pc'.
Comment 5 Aurimas Černius 2011-05-10 18:33:09 UTC 
Changed to uuid.
However, I decided to leave the 0.7 as is, because uuid.pc does not seem to be available on some older systems.
Fix goes to 0.8 only.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.