After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649449 - [gppmux] Failure to write location
[gppmux] Failure to write location
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-05 11:24 UTC by Edward Hervey
Modified: 2011-05-05 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtmux: Fix signed floating point values writing (1.26 KB, patch)
2011-05-05 11:26 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2011-05-05 11:24:13 UTC 
Observed on macosx/32bit

Running suite(s): tagschecking
66%: Checks: 3, Failures: 1, Errors: 0
pipelines/tagschecking.c:213:F:general:test_geo_location_tags:0: tag item geo-location-latitude has been received with different type or value


The problem is that gppmux will write a 'loci' 3gpp location tag with bogus values.

The culprit is :
GST_WRITE_UINT32_BE (data + 1, (guint32) (longitude * 65536.0));

Whereas it's meant to be a signed integer.
Comment 1 Edward Hervey 2011-05-05 11:26:40 UTC 
Created attachment 187275 [details] [review]
qtmux: Fix signed floating point values writing

You would end up on some architectures with 0 being written out
instead of the proper value.
Comment 2 Edward Hervey 2011-05-05 13:13:58 UTC 
commit cca48a42c69d69dcb86ec5ab4c3fd98c9b670731
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Thu May 5 13:24:23 2011 +0200

    qtmux: Fix signed floating point values writing
    
    You would end up on some architectures with 0 being written out
    instead of the proper value.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=649449