GNOME Bugzilla – Bug 649427
After triggering the Activities hotcorner, ignore clicks for a split second
Last modified: 2011-05-19 16:09:38 UTC
I sometimes find myself trying to click the Activities button but accidentally hitting the screen's top-left hotcorner. The result is that I click right after hitting the hotcorner, undoing the action I wanted to do. It is a bit jarring and frustrating, and even though it sounds silly (I can hear you say "you should only use the hotcorner!"), I'm sure that a few users (joe plumber etc.) would experience this. A possible solution would be to ignore clicks on the "Activities" button for ~250 miliseconds after triggering the hotcorner, just to prevent accidents like these.
(In reply to comment #0) > A possible solution would be to ignore clicks on the "Activities" button for > ~250 miliseconds after triggering the hotcorner, just to prevent accidents like > these. We already do ignore clicks on the Activities button for half a second after triggering the hot corner...
Created attachment 187286 [details] [review] panel: Don't propagate button-release-event in _onCornerClicked() Since both the hot corner's ClutterGroup and the hot corner's ClutterRectangle button-release-event is connected to _onCornerClicked() we must handle it there by returning 'true' to Clutter or else _onCornerClicked() is called twice which defeats the HOT_CORNER_ACTIVATION_TIMEOUT logic.
Review of attachment 187286 [details] [review]: This looks good to me and after I figured out exactly when it would matter, seems to test fine. It matters: - If you trigger over view with the mouse hot corner - If the mouse is still on the very corner pixel - Between the point in time where the animation to the overview ends (which is some time after 0.25 seconds - probably usually about 0.4sec depending on the latency to the initial franme) and the end of HOT_CORNER_ACTIVATION_TIMEOUT (0.5sec) (It was easiest to test changing HOT_CORNER_ACTIVATION_TIMEOUT)
I think this one is safe for 3.0.2
Attachment 187286 [details] pushed as 63b1699 - panel: Don't propagate button-release-event in _onCornerClicked()