After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649375 - Strange behavior when using the "add bookmark" button on top-right corner of the panes
Strange behavior when using the "add bookmark" button on top-right corner of ...
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.2.x
Other Linux
: Normal minor
: 1.4
Assigned To: epiotr
epiotr
Depends on:
Blocks:
 
 
Reported: 2011-05-04 14:12 UTC by Alessio Treglia
Modified: 2011-05-09 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for gcmd1.2.8.11 (823 bytes, patch)
2011-05-09 10:40 UTC, Cristian Buzduga
none Details | Review
patch for gcmd 1.4 (805 bytes, patch)
2011-05-09 10:42 UTC, Cristian Buzduga
none Details | Review

Description Alessio Treglia 2011-05-04 14:12:52 UTC
Originally reported here:
https://bugs.launchpad.net/ubuntu/+source/gnome-commander/+bug/743898

Quoted text follows:
------------------------------------
Creating a bookmark for the first time produces a "Label Empty" entry in the Bookmark menu, It is displayed correctly when gnome-commander is restarted. If another bookmark is created then the first one reverts to "Label Empty" and a new "Label Empty" is created. If the program is closed and restarted then both bookmarks show correctly.

Using "Manage Bookmarks" to edit them will also create "Label Empty" entries.
------------------------------------
Comment 1 Cristian Buzduga 2011-05-07 14:33:35 UTC
I couldn't reproduce this bug on my computer. I tried it on latest versions  1.2.8.11 and 1.4 of gnome-commander. I'm using Debian sid (testing) version.
I don't get a "Label Empty" entry on the Bookmarks menu...

But I found another bug, related on this, on both versions: when I use the little bookmark button, which is located on top-right corner of both panes, to add a bookmark, then this bookmark will not be displayed in the "Bookmarks" main menu entry, but only on the popup menu from the same button.
Comment 2 Alessio Treglia 2011-05-08 11:49:06 UTC
Confirmed, this is solved in 1.2.8.11.
Comment 3 Alessio Treglia 2011-05-08 11:54:13 UTC
Re-titling this as per Cristian Buzduga's comment.
Comment 4 Cristian Buzduga 2011-05-09 10:40:59 UTC
Created attachment 187495 [details] [review]
patch for gcmd1.2.8.11

I made a gcmd 1.2.8.11 patch for this issue. The update function of the bookmarks main menu entry was not called when adding a directory from the "add bookmark" button.
Piotr, can you please take a look?
Comment 5 Cristian Buzduga 2011-05-09 10:42:40 UTC
Created attachment 187496 [details] [review]
patch for gcmd 1.4

And this is the attached patch file for gcmd 1.4
Comment 6 epiotr 2011-05-09 18:46:35 UTC
This problem has been fixed in our software repository - both master and gcmd-1-2-8 branches. The fix will go into the next software release. Thank you for your bug report.