After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649319 - Add boiler plate code to xvimagesink
Add boiler plate code to xvimagesink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-03 20:05 UTC by sreerenj
Modified: 2011-06-15 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add boiler plate code to xvimagesink (4.03 KB, patch)
2011-05-03 20:05 UTC, sreerenj 		committed Details | Review

Description sreerenj 2011-05-03 20:05:21 UTC 
Created attachment 187151 [details] [review]
Add boiler plate code to xvimagesink

Add boiler plate code to xvimagesink.
Comment 1 Sebastian Dröge (slomo) 2011-05-04 08:24:30 UTC 
Looks good, I'll push this after release. Note that this doesn't make any functional difference, just saves some lines of code and GST_BOILERPLATE will be gone in 0.11.
Comment 2 Tim-Philipp Müller 2011-05-04 09:12:43 UTC 
Why not just WONTFIX it then? What's the point? Just creates more work.. (</bikeshed>)
Comment 3 sreerenj 2011-05-04 09:22:40 UTC 
Why there is no GST_BOILERPLATE in 0.11 ?
Comment 4 Sebastian Dröge (slomo) 2011-05-04 09:41:31 UTC 
Because it's not necessary anymore, you can use G_DEFINE_TYPE and its variants because it's not required anymore to do something in base_init.
Comment 5 Sebastian Dröge (slomo) 2011-05-14 09:56:54 UTC 
commit cf3cc57ca73040398d34e92fe2336f0aec112b7b
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Tue May 3 11:26:32 2011 +0300

    xvimagesink: Use GST_BOILERPLATE