GNOME Bugzilla – Bug 649296
Folks backend files shouldn't begin with "lib"
Last modified: 2011-08-04 00:20:54 UTC
The existing Folks backend files are named like: ${libdir}/folks/${SO_CURRENT}/backends/${BACKEND_NAME}/ libfolks-backend-${BACKEND_NAME}.so But these are meant to be loaded dynamically, not linked against. So they shouldn't begin with "lib". While we're at it, we should probably cut the module name down to ${BACKEND_NAME}.so. It's still a bit of overkill to have it in its own directory with the same name (${BACKEND_NAME}/${BACKEND_NAME}.so), so we might want to remove the per-backend dirs below ${SO_CURRENT}/backends/
(In reply to comment #0) > The existing Folks backend files are named like: > > ${libdir}/folks/${SO_CURRENT}/backends/${BACKEND_NAME}/ > libfolks-backend-${BACKEND_NAME}.so > > But these are meant to be loaded dynamically, not linked against. So they > shouldn't begin with "lib". While we're at it, we should probably cut the > module name down to ${BACKEND_NAME}.so. It's still a bit of overkill to have it > in its own directory with the same name (${BACKEND_NAME}/${BACKEND_NAME}.so), > so we might want to remove the per-backend dirs below ${SO_CURRENT}/backends/ Dropping the “lib” sounds reasonable (though are there official conventions for library naming written out somewhere?), but I don't see the point in removing the sub-directories. They do no harm, and we might need them in the future.
We should make sure to do this in our next release that breaks API to avoid multiple instances of the same backend (with different names) in <sonumber>/backends/ directory.
Created attachment 193108 [details] [review] Remove the common prefix from backend library filenames https://www.gitorious.org/folks/folks/commits/649296-library-filenames
Whoops, forgot a NEWS entry. I'll add one before committing.
Created attachment 193189 [details] [review] Also update some references to the backend libraries used by some tests
Review of attachment 193108 [details] [review]: Generally looks good, with a minor exception. See the new attachment. Squash my new patch onto this, update NEWS, and please merge.
Comment on attachment 193189 [details] [review] Also update some references to the backend libraries used by some tests Squashed and merged, thanks. commit ca19d32918f94dc4280a3d7a28680f8fecb41cc5 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Tue Aug 2 23:04:58 2011 +0100 Bug 649296 — Folks backend files shouldn't begin with "lib" Rename the backend library files from “libfolks-backend-${BACKEND_NAME}.so” to “${BACKEND_NAME}.so”. Closes: bgo#649296 NEWS | 1 + backends/eds/Makefile.am | 18 +++++++++--------- backends/key-file/Makefile.am | 16 ++++++++-------- backends/libsocialweb/Makefile.am | 18 +++++++++--------- backends/telepathy/Makefile.am | 18 +++++++++--------- backends/tracker/Makefile.am | 18 +++++++++--------- configure.ac | 12 ++++++------ 7 files changed, 51 insertions(+), 50 deletions(-)