After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649202 - Don't call textdomain()
Don't call textdomain()
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-02 16:08 UTC by Dan Winship
Modified: 2011-05-02 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't call textdomain() (1.87 KB, patch)
2011-05-02 16:08 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-05-02 16:08:02 UTC 
As a library, libmutter should not be setting the default translation
domain to point to itself.

Also, move the bindtextdomain() call earlier
(meta_get_option_context), so that translations of command-line
options will be available.

We could call textdomain() in mutter.c, but there's no need to, since
mutter uses dgettext() everywhere anyway.
Comment 1 Dan Winship 2011-05-02 16:08:03 UTC 
Created attachment 187045 [details] [review]
Don't call textdomain()
Comment 2 Owen Taylor 2011-05-02 17:04:04 UTC 
Review of attachment 187045 [details] [review]:

Looks good to me. We'll get another setlocale() call via meta_init() => meta_ui_init() => gtk_init_check(), but I think that's harmless and there's no need to call gtk_disable_setlocale()
Comment 3 Dan Winship 2011-05-02 18:38:08 UTC 
Attachment 187045 [details] pushed as d9007a0 - Don't call textdomain()