GNOME Bugzilla – Bug 649132
Add an option to move button(s) on either side of windows
Last modified: 2017-05-29 19:24:35 UTC
add an option under Gnome Tweak Tool to move button(s) to the left side of windows (like Ubuntu does). I know how to change it under gconf-editor, you just have to move the ":" where you want it. It is used to separate left from right buttons. It could be in the form of a checkbox or a radio button.
Created attachment 216029 [details] [review] patch for Gnome Tweak Tool to move buttons to the Left or the Right side of windows Here is a patch, which adds an option under "Windows" section of Gnome Tweak Tool for moving window buttons to the Left side of windows (like Ubuntu does) or to the Right.
My patch currently works with Gconf instead of GSettings because latest Ubuntu versions still use Gconf-based Metacity 2.34.1 and Compiz in Ubuntu (Unity interface) also uses Gconf key, not GSettings
Review of attachment 216029 [details] [review]: This just conflicts with a similar option in the Shell page of gnome tweak-tool. Such an option to switch the side that the buttons lie on needs to be implemented there, and it needs to handle all combinations of metacity/mutter/gsettings/gconf. Unfortunately this is quite hard because Ubuntu decided to stick with old gconf versions. I will accept a patch that works in all cases, but I will not bother doing it myself, I am tired of working around Ubuntu differences.
Ubuntu 12.10 will use metacity with gsettings so there's no need to bother with gconf. Both Unity and GNOME Fallback use metacity though. I don't think it's possible to implement both mutter and metacity in the same drop-down setting. At least it would be a bit complicated.
(In reply to comment #4) > Ubuntu 12.10 will use metacity with gsettings so there's no need to bother with > gconf. Both Unity and GNOME Fallback use metacity though. > > I don't think it's possible to implement both mutter and metacity in the same > drop-down setting. At least it would be a bit complicated. Cool. What is the delta looking like for the rest of the stack - g-s-d and the old keybindings mechanism comes to mind here.
Keybindings for Unity and Compiz will be using gsettings also. That hasn't landed yet so I can't tell you whether Unity will be using org.gnome.desktop.wm.keybindings or something Compiz-specific. I can't think of any other g-s-d patches that would cause you a problem. Canonical's Desktop Team is skeptical about the ibus work so that particular work may be reverted until 13.04. There was talk about splitting gnome-control-center into gnome-control-center and ubuntu-control-center but that is waiting on the Compiz gsettings work to land first. I'm not sure whether that split is definitely happening or not as I've not really heard it discussed since UDS 2.5 months ago.
*** Bug 724038 has been marked as a duplicate of this bug. ***
Created attachment 352748 [details] [review] windows: Add Left/Right Placement toggle for window buttons Easily switch between Unity-style and GNOME-style placement This patch depends on the "widgets" and "windows" patches from https://bugzilla.gnome.org/783176
Review of attachment 352748 [details] [review]: otherwise looks good, thanks ::: gtweak/tweaks/tweak_group_windows.py @@ -18,2 @@ import gtweak from gtweak.gshellwrapper import GnomeShellFactory you can remove this import too @@ +94,3 @@ + btn1 = Gtk.RadioButton.new_with_label_from_widget(None, _("Left")) + btn1.set_property("draw-indicator", False) + btn1.set_property("draw-indicator", False) duped line? @@ +108,3 @@ + box_btn.pack_start(btn1, True, True, 0) + box_btn.pack_start(btn2, True, True, 0) + self.pack_end(box_btn, False, False, 0) this isn't needed and causes a runtime message inside build_label_beside_widget()
Yes, thank you. I had fixed both those issues locally but hadn't pushed a new patch version here yet.
Attachment 352748 [details] pushed as ca24926 - windows: Add Left/Right Placement toggle for window buttons
Created attachment 352804 [details] [review] windows: Add Left/Right Placement toggle for window buttons Easily switch between Unity-style and GNOME-style placement
Created attachment 352805 [details] [review] split tweak_group_shell.py into separate source files
Created attachment 352806 [details] [review] top_bar: Implement mockup from Design Team
Created attachment 352807 [details] [review] workspaces: Partially implement mockup from Design Team https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png
Created attachment 352808 [details] [review] power: Implement mockup from Design Team The dropped settings were dropped from gnome-settings-daemon in 2012 https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=a95d9c https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=58cb4e
Created attachment 352815 [details] [review] top_bar: Implement mockup from Design Team (Keep "Application Menu" singular for now)
Created attachment 352816 [details] [review] workspaces: Partially implement mockup from Design Team (drop extra whitespace from previous version of this patch)
(In reply to Jeremy Bicha from comment #16) > Created attachment 352808 [details] [review] [review] > power: Implement mockup from Design Team > > The dropped settings were dropped from gnome-settings-daemon in 2012 > https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=a95d9c > https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=58cb4e https://wiki.gnome.org/TranslationProject/DevGuidelines/Don%27t%20mark%20empty%20strings%20for%20translation seems relevant here. :)
Thank you. I had just noticed that issue while trying with a different language, but I hadn't tried to figure out what I had done wrong yet. I meant to attach these patches to bug 783176 so I'll fix that issue and re-attach the patches there instead.