GNOME Bugzilla – Bug 649060
flvmux: overwrites metadata tags with duration in streamable=false mode
Last modified: 2011-05-01 13:22:00 UTC
Created attachment 186957 [details] [review]
Proposed patch to check for streamable prior to duration setting
When trying to use tags (title, artist for example) with flvmux in streamable mode, the tag is overwritten by duration data because it writes into an assumed part of the buffer which isn't valid for streamable=true.
Attached patch adds check for streamable before writing duration into buffer.
On a side-note is there a reason flvmux restricts tags to artist/title only? I have a quick patch that removes this restriction I can submit as a feature req/patch if that makes sense.
Thanks for the patch!
Author: Tom Janiszewski <email@example.com>
Date: Sun May 1 00:04:03 2011 -0400
flvmux: don't overwrite metadata tag with duration in streaming mode
A duration tag gets inserted only for streamable=false, so only
update/write the duration later if we actually inserted that tag,
otherwise we write garbage into other tags.
> On a side-note is there a reason flvmux restricts tags to artist/title only? I
> have a quick patch that removes this restriction I can submit as a feature
> req/patch if that makes sense.
No particular reason probably. I guess mappings for additional tags would could be added, I don't think it makes sense to just randomly write out the GStreamer tag names as tags though (ie. without mapping). Please file a new bug for this if you have additional mappings.