After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649023 - Rows and collumns are contrary
Rows and collumns are contrary
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: F Wolff
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-30 13:25 UTC by Michal Štrba
Modified: 2011-08-31 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested patch (870 bytes, patch)
2011-08-31 10:27 UTC, F Wolff 		none Details | Review

Description Michal Štrba 2011-04-30 13:25:18 UTC 
Set the window size; for example: 80x24, or 80x24+200+200 (ROWSxCOLS+X+Y)

ROWS and COLS are written contrary
Comment 1 Behdad Esfahbod 2011-05-02 00:18:51 UTC 
More details?  Written where?!
Comment 2 F Wolff 2011-08-31 09:27:16 UTC 
The string seems to come from src/terminal-options.c:1037

Michal, can you please describe the issue a bit more?
Comment 3 Michal Štrba 2011-08-31 10:05:58 UTC 
Of course
In the string is written:
"80x24, or 80x24+200+200"
 ^  ^      ^  ^
 C  R      C  R

C: columns
R: rows

But then there is written:
"(ROWSxCOLS+X+Y)"
   ^    ^
   R    C

It's the other way round.
Comment 4 F Wolff 2011-08-31 10:27:52 UTC 
Created attachment 195284 [details] [review]
Suggested patch

Well spotted! Here is my suggested patch. Ok to commit?
Comment 5 Christian Persch 2011-08-31 13:56:57 UTC 
Ok to commit to master, if you handle the string freeze stuff.
Comment 6 F Wolff 2011-08-31 14:43:39 UTC 
Committed with d939a4daa3383722a5d9d46a27b3a978c39bc3d9.