After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649004 - Vte: Vte.Terminal.fork_command_full some arguments can be nullable
Vte: Vte.Terminal.fork_command_full some arguments can be nullable
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-30 09:08 UTC by Jacques-Pascal Deplaix
Modified: 2013-04-16 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch to resolve it (1.53 KB, patch)
2011-04-30 09:08 UTC, Jacques-Pascal Deplaix 		none Details | Review

Description Jacques-Pascal Deplaix 2011-04-30 09:08:58 UTC 
Created attachment 186924 [details] [review]
The patch to resolve it

Vte in version >= 0.26 had the function Vte.Terminal.fork_command_full.

But in the vte vapi file, this function had some arguments non-nullable and some other arguments nullable. That should be the opposite. (see: http://developer.gnome.org/vte/0.26/VteTerminal.html#vte-terminal-fork-command-full)

In the api documentation we can see that argv argument can't be nullable, child_setup can be nullable and child_pid too. For the child_pid case, the argument is not a variable but a pointer nullable.
Comment 1 Luca Bruno 2011-04-30 15:39:29 UTC 
commit c677d391f598f88354467ceb70bc857d28fd04d2
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Sat Apr 30 17:38:10 2011 +0200

    vte: Fix Terminal.fork_command_full binding
    
    Based on patch by Jacques-Pascal Deplaix.
    
    Fixes bug 649004.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Kip 2012-11-21 00:44:03 UTC 
I'm still having difficulties getting child_pid to be accessable. All the other named parameters that I tried appear to work, accept it.

https://bugzilla.gnome.org/show_bug.cgi?id=688699

I am using libvte-2.90 via Python 3 over the GObject introspection interface.
Comment 3 Kip 2013-04-16 08:07:31 UTC 
I realized what I am doing wrong. The child_pid is specified as an out parameter via introspection, so the return value of fork_command_full() is a tuple containing the success code and the child_pid in that order.