After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648980 - Drive's with media tagged as flash, flash_cf, etc. should be automounted.
Drive's with media tagged as flash, flash_cf, etc. should be automounted.
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] gdu volume monitor
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-29 20:06 UTC by ayan.george
Modified: 2011-05-03 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make flash drives automountable. (1.45 KB, patch)
2011-04-29 20:06 UTC, ayan.george 		none Details | Review
Automount flash card readers (1.68 KB, patch)
2011-05-03 05:19 UTC, Martin Pitt 		committed Details | Review

Description ayan.george 2011-04-29 20:06:52 UTC 
Created attachment 186903 [details] [review]
Patch to make flash drives automountable.

gvfs is very cautious about which volumes it automounts and currently only takes into account the type of interconnect -- with only usb, firewire, and sdio being allowd -- and if the device is an optical disc.

We should add logic that makes an exception for flash devices tagged by udisks with ID_DRIVE_FLASH* attributes.

The attached patch implements this feature.
Comment 1 Martin Pitt 2011-05-03 05:03:31 UTC 
For the record, this was reported as automount failure for an internal flash reader which is directly on the PCI bus, not USB (as most flash readers are). See https://launchpad.net/bugs/759963 for details.

The approach of the patch looks fine to me, the "media" property from udisks is a known value. It should just drop the unnecessary drive_media declaration in the second hunk and fix the broken indentation.

Thanks Ayan!
Comment 2 Martin Pitt 2011-05-03 05:19:33 UTC 
Created attachment 187097 [details] [review]
Automount flash card readers

This fixes the indentation and unnecessary declaration, and adds the git changelog.

OK for me to commit?
Comment 3 David Zeuthen (not reading bugmail) 2011-05-03 11:34:19 UTC 
Comment on attachment 187097 [details] [review]
Automount flash card readers

(In reply to comment #2)
> Created an attachment (id=187097) [details] [review]
> Automount flash card readers
> 
> This fixes the indentation and unnecessary declaration, and adds the git
> changelog.
> 
> OK for me to commit?

Looks good to me. Thanks to you and Ayan for tracking this down!

Signed-off-by: David Zeuthen <davidz@redhat.com>
Comment 4 Martin Pitt 2011-05-03 11:54:40 UTC 
Thanks for the review! Pushed.