After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648933 - [mpegvideoparse] Avoid searching for picture start codes when not needed
[mpegvideoparse] Avoid searching for picture start codes when not needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 648932 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-04-29 11:41 UTC by Edward Hervey
Modified: 2011-06-06 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegvideoparse: Avoid double scanning of pictures (1.09 KB, patch)
2011-04-29 11:42 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2011-04-29 11:41:44 UTC 
When parsing the picture header data, mpegvideoparse_handle_picture() scans for all picture start codes.

This is not needed, it can stop scanning when it properly parses the first picture header. And mpegpacketizer will make sure one block will only contain one picture header.

Makes mpegvideoparse two times faster on HD content.
Comment 1 Edward Hervey 2011-04-29 11:42:12 UTC 
Created attachment 186871 [details] [review]
mpegvideoparse: Avoid double scanning of pictures

The incoming data has already been scanned in mpeg_packetizer_add_buf.
We can therefore stop scanning for picture data as soon as we've parsed
the header. Makes mpegvideoparse 2 times faster.
Comment 2 Edward Hervey 2011-04-29 11:44:31 UTC 
*** Bug 648932 has been marked as a duplicate of this bug. ***